crater icon indicating copy to clipboard operation
crater copied to clipboard

"Cannot allocate memory" not recognized as OOM

Open RalfJung opened this issue 5 years ago • 2 comments

I noticed crater started classifying failures as OOM/ICE, which is awesome. :D Here's an example that is misclassified as ICE instead: https://crater-reports.s3.amazonaws.com/pr-71796/try%23b2a885c600d942fb829a214e798f7ae205a0594e/gh/GuyL99.pure-core/log.txt

[INFO] [stderr] thread 'rustc' panicked at 'failed to print diagnostics: Os { code: 12, kind: Other, message: "Cannot allocate memory" }', src/librustc_errors/json.rs:110:13
[INFO] [stderr] stack backtrace:
[INFO] [stderr] error: could not compile `nix`.

RalfJung avatar May 21 '20 17:05 RalfJung

Unfortunately that's not a OOM Crater can currently detect. The current detection code checks whether the kernel had to OOMKill a process, while that error is the allocator refusing to allocate more memory.

pietroalbini avatar May 21 '20 17:05 pietroalbini

It should be feasible to add "Cannot allocate memory" to the OOM detection though, that seems pretty unlikely to come up as a string otherwise.

Mark-Simulacrum avatar May 21 '20 18:05 Mark-Simulacrum