crater icon indicating copy to clipboard operation
crater copied to clipboard

Filter down reverse dependencies

Open yaahc opened this issue 6 years ago • 4 comments

part of https://github.com/rust-lang/crater/issues/440

I don't know how to accurately explain this one, so I will wait for @pietroalbini to come in and fill out a proper issue body.

From our discussion on discord

  • filter down reverse dependencies -- easy enough for crates.io, might be hard with the current model for git repos (it'd be hard for git repos because the crater server doesn't store the git repos, but we could just move the reverse dependencies check to the agent and solve it) for actually running crater, not sure if we have capacity for it on our instances at the moment, the projects would have to run crater on their own (and that's expensive)

yaahc avatar Aug 27 '19 16:08 yaahc

@pietroalbini I'm guessing this one fell through the cracks, but when you have time could you still add a mentoring comment explaining how best to impl this feature?

yaahc avatar Oct 28 '19 18:10 yaahc

Yeah, totally forgot about this. I'll think it over and write the mentoring instructions sometime in the future.

emilyalbini avatar Oct 29 '19 08:10 emilyalbini

@pietroalbini if it's less work for you, don't worry about writing detailed mentoring instructions -- I'm willing to do the work of reading through the source and figuring stuff out, so just a few pointers would be enough to get started :)

hdevalence avatar Oct 31 '19 20:10 hdevalence

Yeah, I thought about this and I think the only viable option is to move the check to the agents.

A flag filter-reverse-dependencies=lazy_static (bikesheddable) can be added to the experiment creation and to the experiment data structure. That way the agent can receive it and, right after a build started, load the dependency graph and set the result to skipped if it's not a reverse dependency.

Performance won't be great as we'll have to still download all the source code on the agents and run the prepare steps, but with git repositories there isn't much more we can do.

emilyalbini avatar Nov 18 '19 12:11 emilyalbini