core-team icon indicating copy to clipboard operation
core-team copied to clipboard

2021 Edition RFC

Open nikomatsakis opened this issue 3 years ago • 20 comments

I just figured I'd add this as a reminder to check in on the 2021 Edition RFC regularly https://github.com/rust-lang/rfcs/pull/2966.

nikomatsakis avatar Aug 05 '20 19:08 nikomatsakis

This issue is an item on the Core Team's public agenda, and the team will discuss it every week during the triage meeting. The goal of the issue is to provide a public record of our discussion, so only members of the Core Team are allowed to comment here.

Please get in touch with the Core Team by emailing [email protected] if you have something to add!

github-actions[bot] avatar Aug 05 '20 19:08 github-actions[bot]

2020-08-05:

Discussion seems to be centered about the question of how much to separate the "retrospective" (what has happened over the last N years?) from the "edition" (what migrations or new lints are required to use edition = X?)

Summary comment of alternative proposal and some further considerations.

nikomatsakis avatar Aug 05 '20 19:08 nikomatsakis

today: just a general "hey check out this RFC, we'll have to decide on it eventually." Lots of comments!

steveklabnik avatar Aug 06 '20 20:08 steveklabnik

Today: niko and I need to chat about the feedback we've gotten, stuff has died down

steveklabnik avatar Aug 13 '20 20:08 steveklabnik

Today: no updates because there were too many things going on in the past week, niko and i are gonna sync up and present a plan next week

steveklabnik avatar Aug 19 '20 15:08 steveklabnik

@nikomatsakis and I had a meeting about it, and he posted a comment on our behalf to get more information about some objections.

steveklabnik avatar Aug 26 '20 15:08 steveklabnik

it has been a busy week. @nikomatsakis and i are gonna talk this week about moving forward.

steveklabnik avatar Sep 02 '20 15:09 steveklabnik

We didn't talk about this this week, but we are trying to move things forward.

steveklabnik avatar Sep 09 '20 15:09 steveklabnik

We also publicly committed to having this ready by October 15th (September 3rd + 6 weeks).

Mark-Simulacrum avatar Sep 09 '20 15:09 Mark-Simulacrum

We talked async a bit, but didn't find a common time to chat yet. Soon!

steveklabnik avatar Sep 16 '20 15:09 steveklabnik

Update: still waiting on folks to review the RFC.

nikomatsakis avatar Oct 14 '20 15:10 nikomatsakis

@ashleygwilliams has left a big review that @nikomatsakis and I need to read and respond to.

steveklabnik avatar Oct 28 '20 15:10 steveklabnik

Niko and Steve plan to sync up later today or this week to make progress on this, but no progress just yet.

Mark-Simulacrum avatar Nov 04 '20 16:11 Mark-Simulacrum

Update from triage: Ashley's concerns mostly apply if this RFC is going to establish editions in general rather than specifically 2021, Niko to tweak the RFC to be 2021-specific and we can establish general edition guidelines in a mini RFC in the future.

(I do think the 2021 edition RFC establishes most important points of editions in general pretty well, but that just means that the general edition RFC can be mostly copy-paste)

Manishearth avatar Nov 11 '20 16:11 Manishearth

Concern: learning from our experience is great but not good for end users (vs maintainers) - are they going to have to read 4 RFCs to understand 'editions'? Not a blocking concern, but our documentation around editions and edition definition needs investment. Ashley would be fine merging if it just applied to next year.

Niko/Steve provided additional context on intent: Ashley found this helpful, but didn't find it was communicated by the RFC Proposal from Mark: "we do an edition next year" the end. Follow up with another RFC that defines the detail

Next steps: Niko/Steve/Ashley to talk separately.

aidanhs avatar Nov 18 '20 16:11 aidanhs

Update: Mark and others have been working on clarifying things

Manishearth avatar Dec 02 '20 16:12 Manishearth

Work is continuing (Mark + others), Niko needs to update the existing RFC thread

aidanhs avatar Dec 09 '20 16:12 aidanhs

Mark thinks there may be a consensus he can pin down in a draft.

Manishearth avatar Dec 16 '20 16:12 Manishearth

Mark created this doc (for core team members only) with the headline "This document outlines a summary of the concerns and proposals on the table for editions in Rust, both with respect to a potential 2021 Edition and the future plans in general."

Mark is now going to arrange meetings with appropriate parties to define the next steps (since they're unclear).

aidanhs avatar Jan 06 '21 16:01 aidanhs

Myself, @Manishearth and @nikomatsakis spoke to Mara last week about edition progress to get an idea of where things lie. We did not get a chance to speak to @Mark-Simulacrum (as a major stakeholder) and will schedule for this coming week. We don't have anything to present at Core team triage this week.

aidanhs avatar Jan 19 '21 21:01 aidanhs