chalk icon indicating copy to clipboard operation
chalk copied to clipboard

Implement should_continue in chalk-recursive

Open detrumi opened this issue 2 years ago • 1 comments

This just returns NoSolution if it shouldn't continue, but that should already be useful to rust-analyzer.

Note: Cloning of should_continue is a workaround to a rustc bug (#95734)

detrumi avatar Aug 23 '22 14:08 detrumi

Build failed because of #775

detrumi avatar Aug 24 '22 06:08 detrumi

Alright, changed it to Ok(Ambig). As for refactoring, would it be useful to add Solution::QuantumExceeded, like AnswerResult::QuantumExceeded in chalk-engine?

detrumi avatar Nov 29 '22 12:11 detrumi

Alright, changed it to Ok(Ambig). As for refactoring, would it be useful to add Solution::QuantumExceeded, like AnswerResult::QuantumExceeded in chalk-engine?

yeah probably

@bors r+

jackh726 avatar Nov 29 '22 22:11 jackh726

:pushpin: Commit f6ac6f5534d4cb91180782ddac7570956ccc1ffe has been approved by jackh726

It is now in the queue for this repository.

bors avatar Nov 29 '22 22:11 bors

:hourglass: Testing commit f6ac6f5534d4cb91180782ddac7570956ccc1ffe with merge 75aa6cf2c69ba5590ff74228d4192bbee0259619...

bors avatar Nov 29 '22 22:11 bors

:sunny: Test successful - checks-actions Approved by: jackh726 Pushing 75aa6cf2c69ba5590ff74228d4192bbee0259619 to master...

bors avatar Nov 29 '22 22:11 bors