chalk icon indicating copy to clipboard operation
chalk copied to clipboard

Allow tests to override the default closure impls

Open JakobDegen opened this issue 3 years ago • 1 comments

In tests, closures can now have explicit Fn* impls, in which case the default impls will no longer be emitted for that closure. These types of impls are restricted to being non-generic over the type. This allows reproducing #688 in a chalk test.

The mechanism for this is an absolute hack; if there's any impl Fn* for MyClosure then the parser will generate a custom LocalImplAllowed clause which is later searched for during WF checking of impls and before emitting default closure impls for that type. The upside of this is that we can re-use the plumbing on the chalk-solve side, especially the WF checking. This probably breaks coherence checking for Fn* traits in tests, but that doesn't seem like an issue.

JakobDegen avatar Nov 15 '21 00:11 JakobDegen

:umbrella: The latest upstream changes (presumably #753) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Mar 09 '22 21:03 bors