cc-rs icon indicating copy to clipboard operation
cc-rs copied to clipboard

Add Loongarch64 support

Open zhaixiaojuan opened this issue 3 years ago • 8 comments

Loongarch is a new RISC architecture. Loongarch doc: https://github.com/loongson-community/LoongArch-Documentation/

zhaixiaojuan avatar Nov 18 '21 11:11 zhaixiaojuan

Thanks! Is there an upstream rust target specification for this target?

alexcrichton avatar Nov 18 '21 15:11 alexcrichton

Yes, the definition of this target is based on the rust target specification. And regarding rust's support for loongarch64 architecture, we are under development.

zhaixiaojuan avatar Nov 19 '21 01:11 zhaixiaojuan

Hm I don't see the target here? https://github.com/rust-lang/rust/tree/master/compiler/rustc_target/src/spec

alexcrichton avatar Nov 19 '21 14:11 alexcrichton

Sorry, we are still testing and developing rust-lang/rust locally. After the testing is completed, we will submit it to the upstream community.

zhaixiaojuan avatar Nov 20 '21 01:11 zhaixiaojuan

Ah ok sounds good, would you be ok if I hold off on merging this until your target is closer to being merged into rust-lang/rust?

alexcrichton avatar Nov 22 '21 16:11 alexcrichton

Of course. However, the integration of rust-lang/rust and its dependent library libc into the community may be a long-term work.

zhaixiaojuan avatar Nov 25 '21 01:11 zhaixiaojuan

If cc-rs can be incorporated into the community, it will be friendly to users of the new architecture, because they do not need to manually adapt it locally every time they use it.

zhaixiaojuan avatar Nov 25 '21 01:11 zhaixiaojuan

Yes that makes sense @zhaixiaojuan, but I prefer to have targets landed in rust-lang/rust before they're added here.

alexcrichton avatar Nov 26 '21 20:11 alexcrichton

@alexcrichton The loongarch64-unknown-linux-gnu was added as a tier 3 target, could you review this patch again please?

heiher avatar Apr 24 '23 14:04 heiher