cc-rs icon indicating copy to clipboard operation
cc-rs copied to clipboard

Add prefer_clang_cl_over_msvc

Open NobodyXu opened this issue 1 year ago • 5 comments

NobodyXu avatar Jan 15 '25 14:01 NobodyXu

cc @madsmtm I am really busy recently and I don't think I can work on this for the next week, if you have time, can you take up this please?

NobodyXu avatar Feb 18 '25 13:02 NobodyXu

cc @madsmtm I am really busy recently and I don't think I can work on this for the next week, if you have time, can you take up this please?

I'd rather not, I don't feel familiar enough with MSVC to feel confident in anything relating to that, sorry :/.

madsmtm avatar Feb 24 '25 00:02 madsmtm

cc @ChrisDenton hello, can you take over this PR please?

I don't have time recently to continue push this.

NobodyXu avatar Feb 27 '25 10:02 NobodyXu

Sure, I've added it to my queue.

ChrisDenton avatar Feb 27 '25 14:02 ChrisDenton

Thank you

NobodyXu avatar Feb 27 '25 14:02 NobodyXu

Is this possibly missing Fixes #882? 🙏

MarijnS95 avatar Aug 04 '25 22:08 MarijnS95

(a) f the user has set TARGET_CC/CC (whichever is relevant) to something other than MSVC, then calling prefer_clang_cl_over_msvc should do nothing. For example, if they've chosen to use clang or (for some reason) GCC, or clang-cl, then prefer_clang_cl_over_msvc shouldn't override that choice.

(b) IDK what to do when the user set TARGET_CC/CC explicitly to MSVC. For my use case the best thing to do would be to choose the clang-cl that's bundled with that install of MSVC.

If the user set TARGET_CC/CC to some version of clang-cl, then I guess we should use that version of clang-cl. But this is handled by (a).

briansmith avatar Aug 05 '25 22:08 briansmith

Closing in favor of #1516

NobodyXu avatar Aug 11 '25 14:08 NobodyXu