cc-rs icon indicating copy to clipboard operation
cc-rs copied to clipboard

Add objects option

Open theaddonn opened this issue 1 year ago • 4 comments

we already have the .object function which allows us to include a single extra object, but if we for example use nasm to generate objects from our asm we get a vector full of paths... here would a .objects function that takes in multiple objects be very helpful!

theaddonn avatar Jul 29 '24 09:07 theaddonn

That sounds like a good addition to the API!

I would welcome any contribution for this feature.

NobodyXu avatar Jul 29 '24 09:07 NobodyXu

I am rn working on a pr, should be finished in a few minutes

theaddonn avatar Jul 29 '24 10:07 theaddonn

pr here we go: https://github.com/rust-lang/cc-rs/pull/1166 hope it's all good :3

theaddonn avatar Jul 29 '24 10:07 theaddonn

Thanks, I've merged it, would cut a release shortly

NobodyXu avatar Jul 29 '24 11:07 NobodyXu

This has been fixed by https://github.com/rust-lang/cc-rs/pull/1166, and can be closed

madsmtm avatar Oct 31 '24 16:10 madsmtm

oh shoot, sorry forgot to close the issue

theaddonn avatar Oct 31 '24 17:10 theaddonn