cargo icon indicating copy to clipboard operation
cargo copied to clipboard

Add a warning when enabling LTO for crates with both cargo-types that support LTO and ones that don't.

Open Lymia opened this issue 8 years ago • 3 comments

As discussed in #2301, cargo silently builds a cdylib without LTO when the same crate also has rlib outputs, as rustc would otherwise error.

The only sign this has happened currently is the output binaries being way larger than expected. A warning would be very helpful for this.

Lymia avatar Oct 12 '17 14:10 Lymia

As there hasn't been any activity here in over 6 months I've marked this as stale and if no further activity happens for 7 days I will close it.

I'm a bot so this may be in error! If this issue should remain open, could someone (the author, a team member, or any interested party) please comment to that effect?

The team would be especially grateful if such a comment included details such as:

  • Is this still relevant?
  • If so, what is blocking it?
  • Is it known what could be done to help move this forward?

Thank you for contributing!

(The cargo team is currently evaluating the use of Stale bot, and using #6035 as the tracking issue to gather feedback.)

If you're reading this comment from the distant future, fear not if this was closed automatically. If you believe it's still an issue please leave a comment and a team member can reopen this issue. Opening a new issue is also acceptable!

stale[bot] avatar Sep 20 '18 03:09 stale[bot]

As far as I am aware, this is still an issue.

Lymia avatar Sep 20 '18 22:09 Lymia

https://github.com/rust-lang/cargo/issues/14612#issue-2554861019 propose to emit a warning suggesting to use cargo rustc --crate-type=X, which is a flag relatively new to this old issue.

I have not yet checked how hard the warning implementation would be. Guess it won't be too hard but a bit gnarly.

weihanglo avatar Nov 09 '24 15:11 weihanglo