cargo icon indicating copy to clipboard operation
cargo copied to clipboard

feat(test-support): Use test name for dir when running tests

Open Muscraft opened this issue 6 months ago • 5 comments

In #11738, I made a test's "sandbox" folder based on its name instead of a generated number, which can change from run to run. #11812 reverted this change due to problems with path length limits on Windows. After getting frustrated with the generated folders while trying to debug a test recently, I decided that it would be a good idea to bring back name-based folders to platforms that support them.

Muscraft avatar Oct 15 '25 20:10 Muscraft

r? @ehuss

rustbot has assigned @ehuss. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar Oct 15 '25 20:10 rustbot

There is some documentation in https://github.com/rust-lang/cargo/blob/HEAD/src/doc/contrib/src/tests/writing.md that would need to be updated.

ehuss avatar Oct 28 '25 14:10 ehuss

@rustbot author

I think @Muscraft indicated he could add some kind of symlink to the first test. There's also the docs to be updated.

ehuss avatar Nov 11 '25 14:11 ehuss

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rustbot avatar Nov 18 '25 14:11 rustbot

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rustbot avatar Dec 02 '25 23:12 rustbot

@Muscraft Is this ready?

ehuss avatar Dec 03 '25 23:12 ehuss

Yes it's ready, I just forgot to mark it as such

@rustbot ready

Muscraft avatar Dec 04 '25 01:12 Muscraft

:umbrella: The latest upstream changes (possibly 2aa0773e6120798d11160a635cb4be9cc9599a68) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot avatar Dec 04 '25 17:12 rustbot