cargo icon indicating copy to clipboard operation
cargo copied to clipboard

fix(git): dont fetch tags by default

Open weihanglo opened this issue 1 year ago • 8 comments

What does this PR try to resolve?

Change Cargo to pass --no-tags Git CLI option by default. This aligns with how libgit2 works in Cargo.

Based on the Git official doc, the flag has been there since at least 2.0.5

How should we test and review this PR?

Not sure if we want a test for this. CARGO_NET_GIT_FETCH_WITH_CLI is barely tested.

Additional information

Fixes #14687

weihanglo avatar Oct 15 '24 03:10 weihanglo

r? @epage

rustbot has assigned @epage. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar Oct 15 '24 03:10 rustbot

Thank you. You're very efficient. I just found this problem point and you've already corrected it.

silence-coding avatar Oct 15 '24 03:10 silence-coding

If we pass a tag to git, will it still be fetched?

epage avatar Oct 15 '24 03:10 epage

By default, any tag that points into the histories being fetched is also fetched; the effect is to fetch tags that point at branches that you are interested in.

So sounds like this isn't saving us in anything we pull. Maybe it reduces server load. It would decrease output noise and reduce the chance of people thinking we are pulling more than we should.

epage avatar Oct 15 '24 03:10 epage

If we pass a tag to git, will it still be fetched?

Yes. I've checked refs/tags. However, it doesn't fetch any tag, even the one we requested. If one switches to other revision and back, the git ref needs to be kinda re-fetched (only git ref, so pretty lightweight). This is the same behavior as our git2 integration.

So sounds like this isn't saving us in anything we pull. Maybe it reduces server load.

Mainly server load, yes, though it also saves like one HTTP POST request and some git command executions. I don't know if it is worthy. Logs attached.

Without --no-tags

    Updating git repository `https://github.com/serde-rs/serde.git`
     Running `git fetch --verbose --force --update-head-ok 'https://github.com/serde-rs/serde.git' '+3ae2bee272cd51ca65162646185043046751dc6d:refs/commit/3ae2bee272cd51ca65162646185043046751dc6d'`
>>>> exec-cmd.c:139          trace: resolved executable path from Darwin stack: /Library/Developer/CommandLineTools/usr/bin/git
>>>> exec-cmd.c:238          trace: resolved executable dir: /Library/Developer/CommandLineTools/usr/bin
>>>> git.c:460               trace: built-in: git fetch --verbose --force --update-head-ok https://github.com/serde-rs/serde.git +3ae2bee272cd51ca65162646185043046751dc6d:refs/commit/3ae2bee272cd51ca65162646185043046751dc6d
>>>> run-command.c:655       trace: run_command: git remote-https https://github.com/serde-rs/serde.git https://github.com/serde-rs/serde.git
>>>> exec-cmd.c:139          trace: resolved executable path from Darwin stack: /Library/Developer/CommandLineTools/usr/libexec/git-core/git
>>>> exec-cmd.c:238          trace: resolved executable dir: /Library/Developer/CommandLineTools/usr/libexec/git-core
>>>> git.c:750               trace: exec: git-remote-https https://github.com/serde-rs/serde.git https://github.com/serde-rs/serde.git
>>>> run-command.c:655       trace: run_command: git-remote-https https://github.com/serde-rs/serde.git https://github.com/serde-rs/serde.git
>>>> exec-cmd.c:139          trace: resolved executable path from Darwin stack: /Library/Developer/CommandLineTools/usr/libexec/git-core/git-remote-https
>>>> exec-cmd.c:238          trace: resolved executable dir: /Library/Developer/CommandLineTools/usr/libexec/git-core
>>>> http.c:725              == Info: Couldn't find host github.com in the .netrc file; using defaults
>>>> http.c:725              == Info: Host github.com:443 was resolved.
>>>> http.c:725              == Info: IPv6: (none)
>>>> http.c:725              == Info: IPv4: 140.82.113.4
>>>> http.c:725              == Info:   Trying 140.82.113.4:443...
>>>> http.c:725              == Info: Connected to github.com (140.82.113.4) port 443
>>>> http.c:725              == Info: ALPN: curl offers h2,http/1.1
>>>> http.c:725              == Info: (304) (OUT), TLS handshake, Client hello (1):
>>>> http.c:725              == Info:  CAfile: /etc/ssl/cert.pem
>>>> http.c:725              == Info:  CApath: none
>>>> http.c:725              == Info: (304) (IN), TLS handshake, Server hello (2):
>>>> http.c:725              == Info: (304) (IN), TLS handshake, Unknown (8):
>>>> http.c:725              == Info: (304) (IN), TLS handshake, Certificate (11):
>>>> http.c:725              == Info: (304) (IN), TLS handshake, CERT verify (15):
>>>> http.c:725              == Info: (304) (IN), TLS handshake, Finished (20):
>>>> http.c:725              == Info: (304) (OUT), TLS handshake, Finished (20):
>>>> http.c:725              == Info: SSL connection using TLSv1.3 / AEAD-CHACHA20-POLY1305-SHA256 / [blank] / UNDEF
>>>> http.c:725              == Info: ALPN: server accepted h2
>>>> http.c:725              == Info: Server certificate:
>>>> http.c:725              == Info:  subject: CN=github.com
>>>> http.c:725              == Info:  start date: Mar  7 00:00:00 2024 GMT
>>>> http.c:725              == Info:  expire date: Mar  7 23:59:59 2025 GMT
>>>> http.c:725              == Info:  subjectAltName: host "github.com" matched cert's "github.com"
>>>> http.c:725              == Info:  issuer: C=GB; ST=Greater Manchester; L=Salford; O=Sectigo Limited; CN=Sectigo ECC Domain Validation Secure Server CA
>>>> http.c:725              == Info:  SSL certificate verify ok.
>>>> http.c:725              == Info: using HTTP/2
>>>> http.c:725              == Info: [HTTP/2] [1] OPENED stream for https://github.com/serde-rs/serde.git/info/refs?service=git-upload-pack
>>>> http.c:725              == Info: [HTTP/2] [1] [:method: GET]
>>>> http.c:725              == Info: [HTTP/2] [1] [:scheme: https]
>>>> http.c:725              == Info: [HTTP/2] [1] [:authority: github.com]
>>>> http.c:725              == Info: [HTTP/2] [1] [:path: /serde-rs/serde.git/info/refs?service=git-upload-pack]
>>>> http.c:725              == Info: [HTTP/2] [1] [user-agent: git/2.39.5 (Apple Git-154)]
>>>> http.c:725              == Info: [HTTP/2] [1] [accept: */*]
>>>> http.c:725              == Info: [HTTP/2] [1] [accept-encoding: deflate, gzip]
>>>> http.c:725              == Info: [HTTP/2] [1] [pragma: no-cache]
>>>> http.c:725              == Info: [HTTP/2] [1] [git-protocol: version=2]
>>>> http.c:672              => Send header, 0000000214 bytes (0x000000d6)
>>>> http.c:684              => Send header: GET /serde-rs/serde.git/info/refs?service=git-upload-pack HTTP/2
>>>> http.c:684              => Send header: Host: github.com
>>>> http.c:684              => Send header: User-Agent: git/2.39.5 (Apple Git-154)
>>>> http.c:684              => Send header: Accept: */*
>>>> http.c:684              => Send header: Accept-Encoding: deflate, gzip
>>>> http.c:684              => Send header: Pragma: no-cache
>>>> http.c:684              => Send header: Git-Protocol: version=2
>>>> http.c:684              => Send header:
>>>> http.c:725              == Info: Request completely sent off
>>>> http.c:672              <= Recv header, 0000000013 bytes (0x0000000d)
>>>> http.c:684              <= Recv header: HTTP/2 200
>>>> http.c:672              <= Recv header, 0000000026 bytes (0x0000001a)
>>>> http.c:684              <= Recv header: server: GitHub-Babel/3.0
>>>> http.c:672              <= Recv header, 0000000059 bytes (0x0000003b)
>>>> http.c:684              <= Recv header: content-type: application/x-git-upload-pack-advertisement
>>>> http.c:672              <= Recv header, 0000000054 bytes (0x00000036)
>>>> http.c:684              <= Recv header: content-security-policy: default-src 'none'; sandbox
>>>> http.c:672              <= Recv header, 0000000040 bytes (0x00000028)
>>>> http.c:684              <= Recv header: expires: Fri, 01 Jan 1980 00:00:00 GMT
>>>> http.c:672              <= Recv header, 0000000018 bytes (0x00000012)
>>>> http.c:684              <= Recv header: pragma: no-cache
>>>> http.c:672              <= Recv header, 0000000053 bytes (0x00000035)
>>>> http.c:684              <= Recv header: cache-control: no-cache, max-age=0, must-revalidate
>>>> http.c:672              <= Recv header, 0000000023 bytes (0x00000017)
>>>> http.c:684              <= Recv header: vary: Accept-Encoding
>>>> http.c:672              <= Recv header, 0000000037 bytes (0x00000025)
>>>> http.c:684              <= Recv header: date: Tue, 15 Oct 2024 03:58:53 GMT
>>>> http.c:672              <= Recv header, 0000000061 bytes (0x0000003d)
>>>> http.c:684              <= Recv header: x-github-request-id: C197:29AC3B:109D2359:166B8CCB:670DE87D
>>>> http.c:672              <= Recv header, 0000000023 bytes (0x00000017)
>>>> http.c:684              <= Recv header: x-frame-options: DENY
>>>> http.c:672              <= Recv header, 0000000002 bytes (0x00000002)
>>>> http.c:684              <= Recv header:
>>>> http.c:725              == Info: Connection #0 to host github.com left intact
POST git-upload-pack (118 bytes)
>>>> http.c:725              == Info: Couldn't find host github.com in the .netrc file; using defaults
>>>> http.c:725              == Info: Found bundle for host: 0x600001c88000 [can multiplex]
>>>> http.c:725              == Info: Re-using existing connection with host github.com
>>>> http.c:725              == Info: [HTTP/2] [3] OPENED stream for https://github.com/serde-rs/serde.git/git-upload-pack
>>>> http.c:725              == Info: [HTTP/2] [3] [:method: POST]
>>>> http.c:725              == Info: [HTTP/2] [3] [:scheme: https]
>>>> http.c:725              == Info: [HTTP/2] [3] [:authority: github.com]
>>>> http.c:725              == Info: [HTTP/2] [3] [:path: /serde-rs/serde.git/git-upload-pack]
>>>> http.c:725              == Info: [HTTP/2] [3] [user-agent: git/2.39.5 (Apple Git-154)]
>>>> http.c:725              == Info: [HTTP/2] [3] [accept-encoding: deflate, gzip]
>>>> http.c:725              == Info: [HTTP/2] [3] [content-type: application/x-git-upload-pack-request]
>>>> http.c:725              == Info: [HTTP/2] [3] [accept: application/x-git-upload-pack-result]
>>>> http.c:725              == Info: [HTTP/2] [3] [git-protocol: version=2]
>>>> http.c:725              == Info: [HTTP/2] [3] [content-length: 118]
>>>> http.c:672              => Send header, 0000000286 bytes (0x0000011e)
>>>> http.c:684              => Send header: POST /serde-rs/serde.git/git-upload-pack HTTP/2
>>>> http.c:684              => Send header: Host: github.com
>>>> http.c:684              => Send header: User-Agent: git/2.39.5 (Apple Git-154)
>>>> http.c:684              => Send header: Accept-Encoding: deflate, gzip
>>>> http.c:684              => Send header: Content-Type: application/x-git-upload-pack-request
>>>> http.c:684              => Send header: Accept: application/x-git-upload-pack-result
>>>> http.c:684              => Send header: Git-Protocol: version=2
>>>> http.c:684              => Send header: Content-Length: 118
>>>> http.c:684              => Send header:
>>>> http.c:725              == Info: upload completely sent off: 118 bytes
>>>> http.c:672              <= Recv header, 0000000013 bytes (0x0000000d)
>>>> http.c:684              <= Recv header: HTTP/2 200
>>>> http.c:672              <= Recv header, 0000000026 bytes (0x0000001a)
>>>> http.c:684              <= Recv header: server: GitHub-Babel/3.0
>>>> http.c:672              <= Recv header, 0000000052 bytes (0x00000034)
>>>> http.c:684              <= Recv header: content-type: application/x-git-upload-pack-result
>>>> http.c:672              <= Recv header, 0000000054 bytes (0x00000036)
>>>> http.c:684              <= Recv header: content-security-policy: default-src 'none'; sandbox
>>>> http.c:672              <= Recv header, 0000000040 bytes (0x00000028)
>>>> http.c:684              <= Recv header: expires: Fri, 01 Jan 1980 00:00:00 GMT
>>>> http.c:672              <= Recv header, 0000000018 bytes (0x00000012)
>>>> http.c:684              <= Recv header: pragma: no-cache
>>>> http.c:672              <= Recv header, 0000000053 bytes (0x00000035)
>>>> http.c:684              <= Recv header: cache-control: no-cache, max-age=0, must-revalidate
>>>> http.c:672              <= Recv header, 0000000023 bytes (0x00000017)
>>>> http.c:684              <= Recv header: vary: Accept-Encoding
>>>> http.c:672              <= Recv header, 0000000037 bytes (0x00000025)
>>>> http.c:684              <= Recv header: date: Tue, 15 Oct 2024 03:58:53 GMT
>>>> http.c:672              <= Recv header, 0000000061 bytes (0x0000003d)
>>>> http.c:684              <= Recv header: x-github-request-id: C197:29AC3B:109D237F:166B8CFD:670DE87D
>>>> http.c:672              <= Recv header, 0000000023 bytes (0x00000017)
>>>> http.c:684              <= Recv header: x-frame-options: DENY
>>>> http.c:672              <= Recv header, 0000000002 bytes (0x00000002)
>>>> http.c:684              <= Recv header:
>>>> http.c:725              == Info: Connection #0 to host github.com left intact
>>>>-pack (233 bytes)
>>>> http.c:725              == Info: Couldn't find host github.com in the .netrc file; using defaults
>>>> http.c:725              == Info: Found bundle for host: 0x600001c88000 [can multiplex]
>>>> http.c:725              == Info: Re-using existing connection with host github.com
>>>> http.c:725              == Info: [HTTP/2] [5] OPENED stream for https://github.com/serde-rs/serde.git/git-upload-pack
>>>> http.c:725              == Info: [HTTP/2] [5] [:method: POST]
>>>> http.c:725              == Info: [HTTP/2] [5] [:scheme: https]
>>>> http.c:725              == Info: [HTTP/2] [5] [:authority: github.com]
>>>> http.c:725              == Info: [HTTP/2] [5] [:path: /serde-rs/serde.git/git-upload-pack]
>>>> http.c:725              == Info: [HTTP/2] [5] [user-agent: git/2.39.5 (Apple Git-154)]
>>>> http.c:725              == Info: [HTTP/2] [5] [accept-encoding: deflate, gzip]
>>>> http.c:725              == Info: [HTTP/2] [5] [content-type: application/x-git-upload-pack-request]
>>>> http.c:725              == Info: [HTTP/2] [5] [accept: application/x-git-upload-pack-result]
>>>> http.c:725              == Info: [HTTP/2] [5] [git-protocol: version=2]
>>>> http.c:725              == Info: [HTTP/2] [5] [content-length: 233]
>>>> http.c:672              => Send header, 0000000286 bytes (0x0000011e)
>>>> http.c:684              => Send header: POST /serde-rs/serde.git/git-upload-pack HTTP/2
>>>> http.c:684              => Send header: Host: github.com
>>>> http.c:684              => Send header: User-Agent: git/2.39.5 (Apple Git-154)
>>>> http.c:684              => Send header: Accept-Encoding: deflate, gzip
>>>> http.c:684              => Send header: Content-Type: application/x-git-upload-pack-request
>>>> http.c:684              => Send header: Accept: application/x-git-upload-pack-result
>>>> http.c:684              => Send header: Git-Protocol: version=2
>>>> http.c:684              => Send header: Content-Length: 233
>>>> http.c:684              => Send header:
>>>> http.c:725              == Info: upload completely sent off: 233 bytes
>>>> http.c:672              <= Recv header, 0000000013 bytes (0x0000000d)
>>>> http.c:684              <= Recv header: HTTP/2 200
>>>> http.c:672              <= Recv header, 0000000026 bytes (0x0000001a)
>>>> http.c:684              <= Recv header: server: GitHub-Babel/3.0
>>>> http.c:672              <= Recv header, 0000000052 bytes (0x00000034)
>>>> http.c:684              <= Recv header: content-type: application/x-git-upload-pack-result
>>>> http.c:672              <= Recv header, 0000000054 bytes (0x00000036)
>>>> http.c:684              <= Recv header: content-security-policy: default-src 'none'; sandbox
>>>> http.c:672              <= Recv header, 0000000040 bytes (0x00000028)
>>>> http.c:684              <= Recv header: expires: Fri, 01 Jan 1980 00:00:00 GMT
>>>> http.c:672              <= Recv header, 0000000018 bytes (0x00000012)
>>>> http.c:684              <= Recv header: pragma: no-cache
>>>> http.c:672              <= Recv header, 0000000053 bytes (0x00000035)
>>>> http.c:684              <= Recv header: cache-control: no-cache, max-age=0, must-revalidate
>>>> http.c:672              <= Recv header, 0000000023 bytes (0x00000017)
>>>> http.c:684              <= Recv header: vary: Accept-Encoding
>>>> http.c:672              <= Recv header, 0000000037 bytes (0x00000025)
>>>> http.c:684              <= Recv header: date: Tue, 15 Oct 2024 03:58:53 GMT
>>>> http.c:672              <= Recv header, 0000000061 bytes (0x0000003d)
>>>> http.c:684              <= Recv header: x-github-request-id: C197:29AC3B:109D23B0:166B8D4A:670DE87D
>>>> http.c:672              <= Recv header, 0000000023 bytes (0x00000017)
>>>> http.c:684              <= Recv header: x-frame-options: DENY
>>>> http.c:672              <= Recv header, 0000000002 bytes (0x00000002)
>>>> http.c:684              <= Recv header:
remote: Enumerating objects: 20486, done.
remote: Counting objects: 100% (194/194), done.
remote: Compressing objects: 100% (190/190), done.
>>>> run-command.c:655       trace: run_command: git index-pack --stdin -v --fix-thin '--keep=fetch-pack 44215 on bcd07442ea13' --pack_header=2,20486
>>>> exec-cmd.c:139          trace: resolved executable path from Darwin stack: /Library/Developer/CommandLineTools/usr/libexec/git-core/git
>>>> exec-cmd.c:238          trace: resolved executable dir: /Library/Developer/CommandLineTools/usr/libexec/git-core
>>>> git.c:460               trace: built-in: git index-pack --stdin -v --fix-thin '--keep=fetch-pack 44215 on bcd07442ea13' --pack_header=2,20486
>>>> http.c:725              == Info: Connection #0 to host github.com left intact
remote: Total 20486 (delta 4), reused 193 (delta 4), pack-reused 20292 (from 1)
Receiving objects: 100% (20486/20486), 5.87 MiB | 33.20 MiB/s, done.
Resolving deltas: 100% (13951/13951), done.
>>>> run-command.c:655       trace: run_command: git rev-list --objects --stdin --not --all --quiet --alternate-refs
>>>> exec-cmd.c:139          trace: resolved executable path from Darwin stack: /Library/Developer/CommandLineTools/usr/libexec/git-core/git
>>>> exec-cmd.c:238          trace: resolved executable dir: /Library/Developer/CommandLineTools/usr/libexec/git-core
>>>> git.c:460               trace: built-in: git rev-list --objects --stdin --not --all --quiet --alternate-refs
From https://github.com/serde-rs/serde
 * [new ref]           3ae2bee272cd51ca65162646185043046751dc6d -> refs/commit/3ae2bee272cd51ca65162646185043046751dc6d
 * [new tag]           v1.0.97    -> v1.0.97
>>>> run-command.c:655       trace: run_command: git remote-https https://github.com/serde-rs/serde.git https://github.com/serde-rs/serde.git
>>>> exec-cmd.c:139          trace: resolved executable path from Darwin stack: /Library/Developer/CommandLineTools/usr/libexec/git-core/git
>>>> exec-cmd.c:238          trace: resolved executable dir: /Library/Developer/CommandLineTools/usr/libexec/git-core
>>>> git.c:750               trace: exec: git-remote-https https://github.com/serde-rs/serde.git https://github.com/serde-rs/serde.git
>>>> run-command.c:655       trace: run_command: git-remote-https https://github.com/serde-rs/serde.git https://github.com/serde-rs/serde.git
>>>> exec-cmd.c:139          trace: resolved executable path from Darwin stack: /Library/Developer/CommandLineTools/usr/libexec/git-core/git-remote-https
>>>> exec-cmd.c:238          trace: resolved executable dir: /Library/Developer/CommandLineTools/usr/libexec/git-core
>>>> run-command.c:655       trace: run_command: git rev-list --objects --stdin --not --all --quiet --alternate-refs
 * [new tag]           v0.2.0     -> v0.2.0
 * [new tag]           v0.2.1     -> v0.2.1
 * [new tag]           v0.3.0     -> v0.3.0
 * [new tag]           v0.3.1     -> v0.3.1
 * [new tag]           v0.3.2     -> v0.3.2
 * [new tag]           v0.3.3     -> v0.3.3
 * [new tag]           v0.4.0     -> v0.4.0
 * [new tag]           v0.4.1     -> v0.4.1
 * [new tag]           v0.4.3     -> v0.4.3
 * [new tag]           v0.4.4     -> v0.4.4
 * [new tag]           v0.5.0     -> v0.5.0
 * [new tag]           v0.5.1     -> v0.5.1
 * [new tag]           v0.5.2     -> v0.5.2
 * [new tag]           v0.5.3     -> v0.5.3
 * [new tag]           v0.6.0     -> v0.6.0
 * [new tag]           v0.6.1     -> v0.6.1
 * [new tag]           v0.6.10    -> v0.6.10
 * [new tag]           v0.6.11    -> v0.6.11
 * [new tag]           v0.6.12    -> v0.6.12
 * [new tag]           v0.6.13    -> v0.6.13
 * [new tag]           v0.6.14    -> v0.6.14
 * [new tag]           v0.6.15    -> v0.6.15
 * [new tag]           v0.6.2     -> v0.6.2
 * [new tag]           v0.6.3     -> v0.6.3
 * [new tag]           v0.6.4     -> v0.6.4
 * [new tag]           v0.6.5     -> v0.6.5
 * [new tag]           v0.6.6     -> v0.6.6
 * [new tag]           v0.6.7     -> v0.6.7
 * [new tag]           v0.6.8     -> v0.6.8
 * [new tag]           v0.6.9     -> v0.6.9
 * [new tag]           v0.7.0     -> v0.7.0
 * [new tag]           v0.7.1     -> v0.7.1
 * [new tag]           v0.7.10    -> v0.7.10
 * [new tag]           v0.7.11    -> v0.7.11
 * [new tag]           v0.7.12    -> v0.7.12
 * [new tag]           v0.7.13    -> v0.7.13
 * [new tag]           v0.7.14    -> v0.7.14
 * [new tag]           v0.7.15    -> v0.7.15
 * [new tag]           v0.7.2     -> v0.7.2
 * [new tag]           v0.7.4     -> v0.7.4
 * [new tag]           v0.7.5     -> v0.7.5
 * [new tag]           v0.7.6     -> v0.7.6
 * [new tag]           v0.7.7     -> v0.7.7
 * [new tag]           v0.7.8     -> v0.7.8
 * [new tag]           v0.7.9     -> v0.7.9
 * [new tag]           v0.8.0     -> v0.8.0
 * [new tag]           v0.8.0-rc1 -> v0.8.0-rc1
 * [new tag]           v0.8.0-rc2 -> v0.8.0-rc2
 * [new tag]           v0.8.0-rc3 -> v0.8.0-rc3
 * [new tag]           v0.8.1     -> v0.8.1
 * [new tag]           v0.8.10    -> v0.8.10
 * [new tag]           v0.8.11    -> v0.8.11
 * [new tag]           v0.8.12    -> v0.8.12
 * [new tag]           v0.8.13    -> v0.8.13
 * [new tag]           v0.8.14    -> v0.8.14
 * [new tag]           v0.8.15    -> v0.8.15
 * [new tag]           v0.8.16    -> v0.8.16
 * [new tag]           v0.8.17    -> v0.8.17
 * [new tag]           v0.8.18    -> v0.8.18
 * [new tag]           v0.8.19    -> v0.8.19
 * [new tag]           v0.8.2     -> v0.8.2
 * [new tag]           v0.8.20    -> v0.8.20
 * [new tag]           v0.8.21    -> v0.8.21
 * [new tag]           v0.8.22    -> v0.8.22
 * [new tag]           v0.8.23    -> v0.8.23
 * [new tag]           v0.8.3     -> v0.8.3
 * [new tag]           v0.8.4     -> v0.8.4
 * [new tag]           v0.8.5     -> v0.8.5
 * [new tag]           v0.8.6     -> v0.8.6
 * [new tag]           v0.8.7     -> v0.8.7
 * [new tag]           v0.8.8     -> v0.8.8
 * [new tag]           v0.8.9     -> v0.8.9
 * [new tag]           v0.9.0     -> v0.9.0
 * [new tag]           v0.9.0-rc1 -> v0.9.0-rc1
 * [new tag]           v0.9.0-rc2 -> v0.9.0-rc2
 * [new tag]           v0.9.0-rc3 -> v0.9.0-rc3
 * [new tag]           v0.9.0-rc4 -> v0.9.0-rc4
 * [new tag]           v0.9.1     -> v0.9.1
 * [new tag]           v0.9.10    -> v0.9.10
 * [new tag]           v0.9.11    -> v0.9.11
 * [new tag]           v0.9.12    -> v0.9.12
 * [new tag]           v0.9.13    -> v0.9.13
 * [new tag]           v0.9.14    -> v0.9.14
 * [new tag]           v0.9.15    -> v0.9.15
 * [new tag]           v0.9.2     -> v0.9.2
 * [new tag]           v0.9.3     -> v0.9.3
 * [new tag]           v0.9.4     -> v0.9.4
 * [new tag]           v0.9.5     -> v0.9.5
 * [new tag]           v0.9.6     -> v0.9.6
 * [new tag]           v0.9.7     -> v0.9.7
 * [new tag]           v0.9.8     -> v0.9.8
 * [new tag]           v0.9.9     -> v0.9.9
 * [new tag]           v1.0.0     -> v1.0.0
 * [new tag]           v1.0.1     -> v1.0.1
 * [new tag]           v1.0.10    -> v1.0.10
 * [new tag]           v1.0.11    -> v1.0.11
 * [new tag]           v1.0.12    -> v1.0.12
 * [new tag]           v1.0.13    -> v1.0.13
 * [new tag]           v1.0.14    -> v1.0.14
 * [new tag]           v1.0.15    -> v1.0.15
 * [new tag]           v1.0.16    -> v1.0.16
 * [new tag]           v1.0.17    -> v1.0.17
 * [new tag]           v1.0.18    -> v1.0.18
 * [new tag]           v1.0.19    -> v1.0.19
 * [new tag]           v1.0.2     -> v1.0.2
 * [new tag]           v1.0.20    -> v1.0.20
 * [new tag]           v1.0.21    -> v1.0.21
 * [new tag]           v1.0.22    -> v1.0.22
 * [new tag]           v1.0.23    -> v1.0.23
 * [new tag]           v1.0.24    -> v1.0.24
 * [new tag]           v1.0.25    -> v1.0.25
 * [new tag]           v1.0.26    -> v1.0.26
 * [new tag]           v1.0.27    -> v1.0.27
 * [new tag]           v1.0.28    -> v1.0.28
 * [new tag]           v1.0.29    -> v1.0.29
 * [new tag]           v1.0.3     -> v1.0.3
 * [new tag]           v1.0.30    -> v1.0.30
 * [new tag]           v1.0.31    -> v1.0.31
 * [new tag]           v1.0.32    -> v1.0.32
 * [new tag]           v1.0.33    -> v1.0.33
 * [new tag]           v1.0.34    -> v1.0.34
 * [new tag]           v1.0.35    -> v1.0.35
 * [new tag]           v1.0.36    -> v1.0.36
 * [new tag]           v1.0.37    -> v1.0.37
 * [new tag]           v1.0.38    -> v1.0.38
 * [new tag]           v1.0.39    -> v1.0.39
 * [new tag]           v1.0.4     -> v1.0.4
 * [new tag]           v1.0.40    -> v1.0.40
 * [new tag]           v1.0.41    -> v1.0.41
 * [new tag]           v1.0.42    -> v1.0.42
 * [new tag]           v1.0.43    -> v1.0.43
 * [new tag]           v1.0.44    -> v1.0.44
 * [new tag]           v1.0.45    -> v1.0.45
 * [new tag]           v1.0.46    -> v1.0.46
 * [new tag]           v1.0.47    -> v1.0.47
 * [new tag]           v1.0.48    -> v1.0.48
 * [new tag]           v1.0.49    -> v1.0.49
 * [new tag]           v1.0.5     -> v1.0.5
 * [new tag]           v1.0.50    -> v1.0.50
 * [new tag]           v1.0.51    -> v1.0.51
 * [new tag]           v1.0.52    -> v1.0.52
 * [new tag]           v1.0.53    -> v1.0.53
 * [new tag]           v1.0.54    -> v1.0.54
 * [new tag]           v1.0.55    -> v1.0.55
 * [new tag]           v1.0.56    -> v1.0.56
 * [new tag]           v1.0.57    -> v1.0.57
 * [new tag]           v1.0.58    -> v1.0.58
 * [new tag]           v1.0.59    -> v1.0.59
 * [new tag]           v1.0.6     -> v1.0.6
 * [new tag]           v1.0.60    -> v1.0.60
 * [new tag]           v1.0.61    -> v1.0.61
 * [new tag]           v1.0.62    -> v1.0.62
 * [new tag]           v1.0.63    -> v1.0.63
 * [new tag]           v1.0.64    -> v1.0.64
 * [new tag]           v1.0.65    -> v1.0.65
 * [new tag]           v1.0.66    -> v1.0.66
 * [new tag]           v1.0.67    -> v1.0.67
 * [new tag]           v1.0.68    -> v1.0.68
 * [new tag]           v1.0.69    -> v1.0.69
 * [new tag]           v1.0.7     -> v1.0.7
 * [new tag]           v1.0.70    -> v1.0.70
 * [new tag]           v1.0.71    -> v1.0.71
 * [new tag]           v1.0.72    -> v1.0.72
 * [new tag]           v1.0.73    -> v1.0.73
 * [new tag]           v1.0.74    -> v1.0.74
 * [new tag]           v1.0.75    -> v1.0.75
 * [new tag]           v1.0.76    -> v1.0.76
 * [new tag]           v1.0.77    -> v1.0.77
 * [new tag]           v1.0.78    -> v1.0.78
 * [new tag]           v1.0.79    -> v1.0.79
 * [new tag]           v1.0.8     -> v1.0.8
 * [new tag]           v1.0.80    -> v1.0.80
 * [new tag]           v1.0.81    -> v1.0.81
 * [new tag]           v1.0.82    -> v1.0.82
 * [new tag]           v1.0.83    -> v1.0.83
 * [new tag]           v1.0.84    -> v1.0.84
 * [new tag]           v1.0.85    -> v1.0.85
 * [new tag]           v1.0.86    -> v1.0.86
 * [new tag]           v1.0.87    -> v1.0.87
 * [new tag]           v1.0.88    -> v1.0.88
 * [new tag]           v1.0.89    -> v1.0.89
 * [new tag]           v1.0.9     -> v1.0.9
 * [new tag]           v1.0.90    -> v1.0.90
 * [new tag]           v1.0.91    -> v1.0.91
 * [new tag]           v1.0.92    -> v1.0.92
 * [new tag]           v1.0.93    -> v1.0.93
 * [new tag]           v1.0.94    -> v1.0.94
 * [new tag]           v1.0.95    -> v1.0.95
 * [new tag]           v1.0.96    -> v1.0.96
>>>> run-command.c:655       trace: run_command: git maintenance run --auto --no-quiet
>>>> exec-cmd.c:139          trace: resolved executable path from Darwin stack: /Library/Developer/CommandLineTools/usr/libexec/git-core/git
>>>> exec-cmd.c:238          trace: resolved executable dir: /Library/Developer/CommandLineTools/usr/libexec/git-core
>>>> git.c:460               trace: built-in: git maintenance run --auto --no-quiet
       Fresh serde v1.0.97 (https://github.com/serde-rs/serde.git?tag=v1.0.97#3ae2bee2)
       Fresh bar v0.1.0 (/Users/weihanglo/projects/bar)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.01s

With --no-tags

    Updating git repository `https://github.com/serde-rs/serde.git`
     Running `git fetch --no-tags --verbose --force --update-head-ok 'https://github.com/serde-rs/serde.git' '+3ae2bee
>>>> exec-cmd.c:139          trace: resolved executable path from Darwin stack: /Library/Developer/CommandL
>>>> exec-cmd.c:238          trace: resolved executable dir: /Library/Developer/CommandLineTools/usr/bin
>>>> git.c:460               trace: built-in: git fetch --no-tags --verbose --force --update-head-ok https:
>>>> run-command.c:655       trace: run_command: git remote-https https://github.com/serde-rs/serde.git htt
>>>> exec-cmd.c:139          trace: resolved executable path from Darwin stack: /Library/Developer/CommandL
>>>> exec-cmd.c:238          trace: resolved executable dir: /Library/Developer/CommandLineTools/usr/libexe
>>>> git.c:750               trace: exec: git-remote-https https://github.com/serde-rs/serde.git https://gi
>>>> run-command.c:655       trace: run_command: git-remote-https https://github.com/serde-rs/serde.git htt
>>>> exec-cmd.c:139          trace: resolved executable path from Darwin stack: /Library/Developer/CommandL
>>>> exec-cmd.c:238          trace: resolved executable dir: /Library/Developer/CommandLineTools/usr/libexe
>>>> http.c:725              == Info: Couldn't find host github.com in the .netrc file; using defaults
>>>> http.c:725              == Info: Host github.com:443 was resolved.
>>>> http.c:725              == Info: IPv6: (none)
>>>> http.c:725              == Info: IPv4: 140.82.112.3
>>>> http.c:725              == Info:   Trying 140.82.112.3:443...
>>>> http.c:725              == Info: Connected to github.com (140.82.112.3) port 443
>>>> http.c:725              == Info: ALPN: curl offers h2,http/1.1
>>>> http.c:725              == Info: (304) (OUT), TLS handshake, Client hello (1):
>>>> http.c:725              == Info:  CAfile: /etc/ssl/cert.pem
>>>> http.c:725              == Info:  CApath: none
>>>> http.c:725              == Info: (304) (IN), TLS handshake, Server hello (2):
>>>> http.c:725              == Info: (304) (IN), TLS handshake, Unknown (8):
>>>> http.c:725              == Info: (304) (IN), TLS handshake, Certificate (11):
>>>> http.c:725              == Info: (304) (IN), TLS handshake, CERT verify (15):
>>>> http.c:725              == Info: (304) (IN), TLS handshake, Finished (20):
>>>> http.c:725              == Info: (304) (OUT), TLS handshake, Finished (20):
>>>> http.c:725              == Info: SSL connection using TLSv1.3 / AEAD-CHACHA20-POLY1305-SHA256 / [blank
>>>> http.c:725              == Info: ALPN: server accepted h2
>>>> http.c:725              == Info: Server certificate:
>>>> http.c:725              == Info:  subject: CN=github.com
>>>> http.c:725              == Info:  start date: Mar  7 00:00:00 2024 GMT
>>>> http.c:725              == Info:  expire date: Mar  7 23:59:59 2025 GMT
>>>> http.c:725              == Info:  subjectAltName: host "github.com" matched cert's "github.com"
>>>> http.c:725              == Info:  issuer: C=GB; ST=Greater Manchester; L=Salford; O=Sectigo Limited; C
>>>> http.c:725              == Info:  SSL certificate verify ok.
>>>> http.c:725              == Info: using HTTP/2
>>>> http.c:725              == Info: [HTTP/2] [1] OPENED stream for https://github.com/serde-rs/serde.git/
>>>> http.c:725              == Info: [HTTP/2] [1] [:method: GET]
>>>> http.c:725              == Info: [HTTP/2] [1] [:scheme: https]
>>>> http.c:725              == Info: [HTTP/2] [1] [:authority: github.com]
>>>> http.c:725              == Info: [HTTP/2] [1] [:path: /serde-rs/serde.git/info/refs?service=git-upload
>>>> http.c:725              == Info: [HTTP/2] [1] [user-agent: git/2.39.5 (Apple Git-154)]
>>>> http.c:725              == Info: [HTTP/2] [1] [accept: */*]
>>>> http.c:725              == Info: [HTTP/2] [1] [accept-encoding: deflate, gzip]
>>>> http.c:725              == Info: [HTTP/2] [1] [pragma: no-cache]
>>>> http.c:725              == Info: [HTTP/2] [1] [git-protocol: version=2]
>>>> http.c:672              => Send header, 0000000214 bytes (0x000000d6)
>>>> http.c:684              => Send header: GET /serde-rs/serde.git/info/refs?service=git-upload-pack HTTP
>>>> http.c:684              => Send header: Host: github.com
>>>> http.c:684              => Send header: User-Agent: git/2.39.5 (Apple Git-154)
>>>> http.c:684              => Send header: Accept: */*
>>>> http.c:684              => Send header: Accept-Encoding: deflate, gzip
>>>> http.c:684              => Send header: Pragma: no-cache
>>>> http.c:684              => Send header: Git-Protocol: version=2
>>>> http.c:684              => Send header:
>>>> http.c:725              == Info: Request completely sent off
>>>> http.c:672              <= Recv header, 0000000013 bytes (0x0000000d)
>>>> http.c:684              <= Recv header: HTTP/2 200
>>>> http.c:672              <= Recv header, 0000000026 bytes (0x0000001a)
>>>> http.c:684              <= Recv header: server: GitHub-Babel/3.0
>>>> http.c:672              <= Recv header, 0000000059 bytes (0x0000003b)
>>>> http.c:684              <= Recv header: content-type: application/x-git-upload-pack-advertisement
>>>> http.c:672              <= Recv header, 0000000054 bytes (0x00000036)
>>>> http.c:684              <= Recv header: content-security-policy: default-src 'none'; sandbox
>>>> http.c:672              <= Recv header, 0000000040 bytes (0x00000028)
>>>> http.c:684              <= Recv header: expires: Fri, 01 Jan 1980 00:00:00 GMT
>>>> http.c:672              <= Recv header, 0000000018 bytes (0x00000012)
>>>> http.c:684              <= Recv header: pragma: no-cache
>>>> http.c:672              <= Recv header, 0000000053 bytes (0x00000035)
>>>> http.c:684              <= Recv header: cache-control: no-cache, max-age=0, must-revalidate
>>>> http.c:672              <= Recv header, 0000000023 bytes (0x00000017)
>>>> http.c:684              <= Recv header: vary: Accept-Encoding
>>>> http.c:672              <= Recv header, 0000000037 bytes (0x00000025)
>>>> http.c:684              <= Recv header: date: Tue, 15 Oct 2024 04:01:18 GMT
>>>> http.c:672              <= Recv header, 0000000058 bytes (0x0000003a)
>>>> http.c:684              <= Recv header: x-github-request-id: C1D0:C42C7:338DA82:47E25EF:670DE90E
>>>> http.c:672              <= Recv header, 0000000023 bytes (0x00000017)
>>>> http.c:684              <= Recv header: x-frame-options: DENY
>>>> http.c:672              <= Recv header, 0000000002 bytes (0x00000002)
>>>> http.c:684              <= Recv header:
>>>> http.c:725              == Info: Connection #0 to host github.com left intact
POST git-upload-pack (168 bytes)
>>>> http.c:725              == Info: Couldn't find host github.com in the .netrc file; using defaults
>>>> http.c:725              == Info: Found bundle for host: 0x6000000203c0 [can multiplex]
>>>> http.c:725              == Info: Re-using existing connection with host github.com
>>>> http.c:725              == Info: [HTTP/2] [3] OPENED stream for https://github.com/serde-rs/serde.git/
>>>> http.c:725              == Info: [HTTP/2] [3] [:method: POST]
>>>> http.c:725              == Info: [HTTP/2] [3] [:scheme: https]
>>>> http.c:725              == Info: [HTTP/2] [3] [:authority: github.com]
>>>> http.c:725              == Info: [HTTP/2] [3] [:path: /serde-rs/serde.git/git-upload-pack]
>>>> http.c:725              == Info: [HTTP/2] [3] [user-agent: git/2.39.5 (Apple Git-154)]
>>>> http.c:725              == Info: [HTTP/2] [3] [accept-encoding: deflate, gzip]
>>>> http.c:725              == Info: [HTTP/2] [3] [content-type: application/x-git-upload-pack-request]
>>>> http.c:725              == Info: [HTTP/2] [3] [accept: application/x-git-upload-pack-result]
>>>> http.c:725              == Info: [HTTP/2] [3] [git-protocol: version=2]
>>>> http.c:725              == Info: [HTTP/2] [3] [content-length: 168]
>>>> http.c:672              => Send header, 0000000286 bytes (0x0000011e)
>>>> http.c:684              => Send header: POST /serde-rs/serde.git/git-upload-pack HTTP/2
>>>> http.c:684              => Send header: Host: github.com
>>>> http.c:684              => Send header: User-Agent: git/2.39.5 (Apple Git-154)
>>>> http.c:684              => Send header: Accept-Encoding: deflate, gzip
>>>> http.c:684              => Send header: Content-Type: application/x-git-upload-pack-request
>>>> http.c:684              => Send header: Accept: application/x-git-upload-pack-result
>>>> http.c:684              => Send header: Git-Protocol: version=2
>>>> http.c:684              => Send header: Content-Length: 168
>>>> http.c:684              => Send header:
>>>> http.c:725              == Info: upload completely sent off: 168 bytes
>>>> http.c:672              <= Recv header, 0000000013 bytes (0x0000000d)
>>>> http.c:684              <= Recv header: HTTP/2 200
>>>> http.c:672              <= Recv header, 0000000026 bytes (0x0000001a)
>>>> http.c:684              <= Recv header: server: GitHub-Babel/3.0
>>>> http.c:672              <= Recv header, 0000000052 bytes (0x00000034)
>>>> http.c:684              <= Recv header: content-type: application/x-git-upload-pack-result
>>>> http.c:672              <= Recv header, 0000000054 bytes (0x00000036)
>>>> http.c:684              <= Recv header: content-security-policy: default-src 'none'; sandbox
>>>> http.c:672              <= Recv header, 0000000040 bytes (0x00000028)
>>>> http.c:684              <= Recv header: expires: Fri, 01 Jan 1980 00:00:00 GMT
>>>> http.c:672              <= Recv header, 0000000018 bytes (0x00000012)
>>>> http.c:684              <= Recv header: pragma: no-cache
>>>> http.c:672              <= Recv header, 0000000053 bytes (0x00000035)
>>>> http.c:684              <= Recv header: cache-control: no-cache, max-age=0, must-revalidate
>>>> http.c:672              <= Recv header, 0000000023 bytes (0x00000017)
>>>> http.c:684              <= Recv header: vary: Accept-Encoding
>>>> http.c:672              <= Recv header, 0000000037 bytes (0x00000025)
>>>> http.c:684              <= Recv header: date: Tue, 15 Oct 2024 04:01:17 GMT
>>>> http.c:672              <= Recv header, 0000000058 bytes (0x0000003a)
>>>> http.c:684              <= Recv header: x-github-request-id: C1D0:C42C7:338DAA9:47E262C:670DE90E
>>>> http.c:672              <= Recv header, 0000000023 bytes (0x00000017)
>>>> http.c:684              <= Recv header: x-frame-options: DENY
>>>> http.c:672              <= Recv header, 0000000002 bytes (0x00000002)
>>>> http.c:684              <= Recv header:
remote: Enumerating objects: 20296, done.
remote: Counting objects: 100% (5/5), done.
>>>> run-command.c:655       trace: run_command: git index-pack --stdin -v --fix-thin '--keep=fetch-pack 44492 on bcd07442ea13' --pack_header=2,20296
>>>> exec-cmd.c:139          trace: resolved executable path from Darwin stack: /Library/Developer/CommandLineTools/usr/libexec/git-core/git
>>>> exec-cmd.c:238          trace: resolved executable dir: /Library/Developer/CommandLineTools/usr/libexec/git-core
>>>> git.c:460               trace: built-in: git index-pack --stdin -v --fix-thin '--keep=fetch-pack 44492 on bcd07442ea13' --pack_header=2,20296
>>>> http.c:725              == Info: Connection #0 to host github.com left intact
remote: Total 20296 (delta 4), reused 4 (delta 4), pack-reused 20291 (from 1)
Receiving objects: 100% (20296/20296), 5.87 MiB | 23.95 MiB/s, done.
Resolving deltas: 100% (13954/13954), done.
>>>> run-command.c:655       trace: run_command: git rev-list --objects --stdin --not --all --quiet --alternate-refs
>>>> exec-cmd.c:139          trace: resolved executable path from Darwin stack: /Library/Developer/CommandLineTools/usr/libexec/git-core/git
>>>> exec-cmd.c:238          trace: resolved executable dir: /Library/Developer/CommandLineTools/usr/libexec/git-core
>>>> git.c:460               trace: built-in: git rev-list --objects --stdin --not --all --quiet --alternate-refs
From https://github.com/serde-rs/serde
 * [new ref]           3ae2bee272cd51ca65162646185043046751dc6d -> refs/commit/3ae2bee272cd51ca65162646185043046751dc6d
>>>> run-command.c:655       trace: run_command: git maintenance run --auto --no-quiet
>>>> exec-cmd.c:139          trace: resolved executable path from Darwin stack: /Library/Developer/CommandLineTools/usr/libexec/git-core/git
>>>> exec-cmd.c:238          trace: resolved executable dir: /Library/Developer/CommandLineTools/usr/libexec/git-core
>>>> git.c:460               trace: built-in: git maintenance run --auto --no-quiet
       Fresh serde v1.0.97 (https://github.com/serde-rs/serde.git?tag=v1.0.97#3ae2bee2)
       Fresh bar v0.1.0 (/Users/weihanglo/projects/bar)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.92s

weihanglo avatar Oct 15 '24 04:10 weihanglo

Just from the user confusion aspect, its likely worth it

@bors r+

epage avatar Oct 15 '24 04:10 epage

:pushpin: Commit 1975c3ca530e4e168f517275c45a32a3b1b3a3bc has been approved by epage

It is now in the queue for this repository.

bors avatar Oct 15 '24 04:10 bors

:hourglass: Testing commit 1975c3ca530e4e168f517275c45a32a3b1b3a3bc with merge 3c4c0a2b3c9df8f2e97b58358ce1b36ecc81bc5c...

bors avatar Oct 15 '24 04:10 bors

:sunny: Test successful - checks-actions Approved by: epage Pushing 3c4c0a2b3c9df8f2e97b58358ce1b36ecc81bc5c to master...

bors avatar Oct 15 '24 05:10 bors