cargo icon indicating copy to clipboard operation
cargo copied to clipboard

Added unstable-schema generation for Cargo.toml

Open dacianpascu06 opened this issue 1 year ago • 2 comments

What does this PR try to resolve?

Added unstable-schema feature that generates JsonSchema for Cargo.toml

See #12883 finished first step of plan

Information

In cargo-util-schemas, run cargo test --feature unstable-schema . If there have been any changes to schema.json, rerun with env variable SNAPSHOTS=overwrite and it will update them.

How should we test and review this PR?

In cargo-util-schemas run cargo test --features unstable-schema and it will generate schema.json

dacianpascu06 avatar Oct 14 '24 11:10 dacianpascu06

r? @weihanglo

rustbot has assigned @weihanglo. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar Oct 14 '24 11:10 rustbot

Please cleanup the commits for how you'd like them reviewed / merged.

epage avatar Oct 14 '24 16:10 epage

Thanks!

@bors r+

epage avatar Oct 23 '24 19:10 epage

:pushpin: Commit 1f419ba6fc934a053f598442c018bb8fb007904b has been approved by epage

It is now in the queue for this repository.

bors avatar Oct 23 '24 19:10 bors

:hourglass: Testing commit 1f419ba6fc934a053f598442c018bb8fb007904b with merge 4d4130a45e45f6d5fce25edc930725bf99a60c40...

bors avatar Oct 23 '24 19:10 bors

@bors r-

Looks like some unrelated lockfile updates happened

weihanglo avatar Oct 23 '24 19:10 weihanglo

:sunny: Try build successful - checks-actions Build commit: 4d4130a45e45f6d5fce25edc930725bf99a60c40 (4d4130a45e45f6d5fce25edc930725bf99a60c40)

bors avatar Oct 23 '24 19:10 bors

Thanks!

@bors r+

epage avatar Oct 24 '24 21:10 epage

:pushpin: Commit 21ce69ef376153efbe1308e466a9df795712a13b has been approved by epage

It is now in the queue for this repository.

bors avatar Oct 24 '24 21:10 bors

:hourglass: Testing commit 21ce69ef376153efbe1308e466a9df795712a13b with merge cf9152007eb7221c91b6c298520dd0707d11bb9c...

bors avatar Oct 24 '24 21:10 bors

:sunny: Test successful - checks-actions Approved by: epage Pushing cf9152007eb7221c91b6c298520dd0707d11bb9c to master...

bors avatar Oct 24 '24 21:10 bors