cargo icon indicating copy to clipboard operation
cargo copied to clipboard

test: Migrate publish snapshotting to snapbox

Open epage opened this issue 1 year ago • 1 comments

What does this PR try to resolve?

This is part of #14039 and allows snapshotting in more places.

How should we test and review this PR?

Additional information

InMemoryDir is taken from some experiments I've been doing in snapshot for filesystem assertions. That got held up because of design complexity but publish validation's needs are simpler than I was designing for.

epage avatar Oct 04 '24 17:10 epage

r? @weihanglo

rustbot has assigned @weihanglo. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar Oct 04 '24 17:10 rustbot

@bors r=weihanglo

epage avatar Oct 16 '24 23:10 epage

:pushpin: Commit 5b84fc99c55a57bfb6e1d9dc84bbc8b7f1b9bb43 has been approved by weihanglo

It is now in the queue for this repository.

bors avatar Oct 16 '24 23:10 bors

:hourglass: Testing commit 5b84fc99c55a57bfb6e1d9dc84bbc8b7f1b9bb43 with merge 2835ddc2cc0771cc57eea170d0707fff42ea2c62...

bors avatar Oct 16 '24 23:10 bors

:sunny: Test successful - checks-actions Approved by: weihanglo Pushing 2835ddc2cc0771cc57eea170d0707fff42ea2c62 to master...

bors avatar Oct 17 '24 00:10 bors

:sunny: Test successful - checks-actions Approved by: weihanglo Pushing 2835ddc2cc0771cc57eea170d0707fff42ea2c62 to master...

bors avatar Oct 17 '24 00:10 bors

:eyes: Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

bors avatar Oct 17 '24 00:10 bors