cargo icon indicating copy to clipboard operation
cargo copied to clipboard
verified publisher icon rust-lang

git: do not validate submodules of fresh checkouts

Open osiewicz opened this issue 1 year ago • 3 comments

Fixes #14603

What does this PR try to resolve?

As is, we unconditionally validate freshness of the submodules of a checkout, even though we could assume that a fresh checkout has to have up-to-date submodules as well.

How should we test and review this PR?

N/A

Additional information

N/A

osiewicz avatar Sep 27 '24 00:09 osiewicz

r? @weihanglo

rustbot has assigned @weihanglo. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar Sep 27 '24 00:09 rustbot

We likely should update _corrupted_checkout test to have a submodule to show that we recovery gracefully on interruption,

epage avatar Sep 27 '24 00:09 epage

Could you update the commits to be how you want them reviewed and merged?

For example, I could see this being

  • Test commit
  • Refactor for checkout guard
  • Improve performance by adjusting the scope of the checkout guard

epage avatar Oct 01 '24 18:10 epage

FYI ecb63986881a66020fbe599b8775485e58607b7b was what I was asking for in splitting out a refactor commit. It makes it easier to follow what is intended with the actual performance fix.

epage avatar Nov 11 '24 22:11 epage