cargo icon indicating copy to clipboard operation
cargo copied to clipboard

Verify build-std resolve against original lockfile

Open adamgemmell opened this issue 1 year ago • 2 comments

What does this PR try to resolve?

Ensures that the resolve of the standard library when using build-std is a subset of the lockfile from the library source, as per discussion on rust-lang/wg-cargo-std-aware#38. It is a runtime version of the test added here: https://github.com/rust-lang/cargo/pull/13404

Fixes https://github.com/rust-lang/wg-cargo-std-aware/issues/38

How should we test and review this PR?

It can be manually tested by running cargo build -Zbuild-std --target=[host] and seeing the command succeed. I'm not sure what behaviour can exercise the negative test case.

Additional information

Co-authored-by: Lawrence Tang [email protected]

adamgemmell avatar May 15 '24 11:05 adamgemmell

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot avatar May 15 '24 11:05 rustbot

r? @ehuss

(nvm, I forgot a file 🙃)

adamgemmell avatar May 15 '24 11:05 adamgemmell

@rustbot author

weihanglo avatar Jul 01 '24 16:07 weihanglo

:umbrella: The latest upstream changes (presumably #14358) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Aug 06 '24 12:08 bors