cargo icon indicating copy to clipboard operation
cargo copied to clipboard

Fix target entry in .gitignore

Open rukai opened this issue 2 months ago • 1 comments

The directories at:

  • https://github.com/rust-lang/cargo/tree/master/tests/testsuite/cargo_remove/target
  • https://github.com/rust-lang/cargo/tree/master/tests/testsuite/cargo_add/target

Are getting picked up by the target entry in .gitignore, causing git to ignore any extra files added to those directories. A minor issue I know, but I still think its worth fixing.

Alternative

An alternative solution would be to rename those directories which I'm more than happy to do. But I think we are better off just changing .gitignore as that is more future proof.

rukai avatar Apr 28 '24 08:04 rukai

r? @ehuss

rustbot has assigned @ehuss. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar Apr 28 '24 08:04 rustbot

@bors r+

weihanglo avatar Apr 29 '24 13:04 weihanglo

:pushpin: Commit 433635b9fe720cf7d11d2de52dc6b24548790cd1 has been approved by weihanglo

It is now in the queue for this repository.

bors avatar Apr 29 '24 13:04 bors

:hourglass: Testing commit 433635b9fe720cf7d11d2de52dc6b24548790cd1 with merge 080869e835d4843075201482b0c80fcf143a870a...

bors avatar Apr 29 '24 13:04 bors

:sunny: Test successful - checks-actions Approved by: weihanglo Pushing 080869e835d4843075201482b0c80fcf143a870a to master...

bors avatar Apr 29 '24 14:04 bors