fix(toml)!: Remove support for inheriting badges

[epage]

What does this PR try to resolve?

We allowed [badges] to inherit from [workspace.package.badges] which was a bug:

• This was not specified in the RFC
• We did not document this
• Even if someone were to try to guess to use this, it is inconsistent with how inheritance works because this should inherit from workspace.badges instead of workspace.package.badges

While keeping in mind that [badges] is effectively deprecated.

In that context, I think its safe to break support for this without a transition period.

Fixes #13643

How should we test and review this PR?

Additional information

[rustbot]

r? @weihanglo

rustbot has assigned @weihanglo. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[weihanglo]

As this is sort of a breaking change to an undocumented behavior that shouldn't have happened for a deprecated field, I'd like to start a poll.

(not going to wait for a full 10-days FCP after we reach a consensus)

@rfcbot fcp merge

[rfcbot]

Team member @weihanglo has proposed to merge this. The next step is review by the rest of the tagged team members:

• [x] @Eh2406
• [x] @Muscraft
• [ ] @arlosi
• [x] @ehuss
• [x] @epage
• [ ] @joshtriplett
• [x] @weihanglo

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

[rfcbot]

:bell: This is now entering its final comment period, as per the review above. :bell:

[weihanglo]

@bors r+

Thanks for the update.

[bors]

:pushpin: Commit bdd4bda518d12dda6c265e48bc27cfb2fdb2db94 has been approved by weihanglo

It is now in the queue for this repository.

[bors]

:hourglass: Testing commit bdd4bda518d12dda6c265e48bc27cfb2fdb2db94 with merge cc20b551cef44eba5f09b6d5624259cf4dcc2992...

[bors]

:sunny: Test successful - checks-actions Approved by: weihanglo Pushing cc20b551cef44eba5f09b6d5624259cf4dcc2992 to master...