cargo icon indicating copy to clipboard operation
cargo copied to clipboard

Published 20 hours ago • verified publisher icon rust-lang

Add retry support to sparse registries

Open arlosi opened this issue 2 years ago • 4 comments

Sparse (HTTP) registries currently do not respect Cargo's retry policy for http requests.

This change makes sparse registries use the same retry system as package downloads.

arlosi avatar Sep 09 '22 21:09 arlosi

r? @epage

(rust-highfive has picked a reviewer for you, use r? to override)

rust-highfive avatar Sep 09 '22 21:09 rust-highfive

r? @Eh2406

epage avatar Sep 09 '22 21:09 epage

:umbrella: The latest upstream changes (presumably #11068) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Sep 09 '22 22:09 bors

Had some time to look this over and it looks good to me. Ed has some good questions about nomenclature. Is there some way we can add tests? Perhaps a setup like #11062 where the server takes a few tries to give a 200.

Eh2406 avatar Sep 11 '22 02:09 Eh2406

I pulled in the test framework changes from #11062 and added a test.

arlosi avatar Oct 07 '22 17:10 arlosi

@bors r+

Eh2406 avatar Oct 07 '22 19:10 Eh2406

:pushpin: Commit dcc512b31746cc10a012aae6ad47eada14ed6b06 has been approved by Eh2406

It is now in the queue for this repository.

bors avatar Oct 07 '22 19:10 bors

:hourglass: Testing commit dcc512b31746cc10a012aae6ad47eada14ed6b06 with merge d1a2592265787164f1daec9d6d92a85ed306fbdb...

bors avatar Oct 07 '22 19:10 bors

:sunny: Test successful - checks-actions Approved by: Eh2406 Pushing d1a2592265787164f1daec9d6d92a85ed306fbdb to master...

bors avatar Oct 07 '22 20:10 bors