cargo-bisect-rustc icon indicating copy to clipboard operation
cargo-bisect-rustc copied to clipboard

Expected author Brian Anderson to be bors

Open nagisa opened this issue 5 years ago • 5 comments

bisecting ci builds
starting at a01b0bf0fbd870bec1747318bc081ac4a0606fb8, ending at 2442823ef572a65092fbc46f6975633f983b50b6
fetching commits from a01b0bf0fbd870bec1747318bc081ac4a0606fb8 to 2442823ef572a65092fbc46f6975633f983b50b6
opening existing repository at "rust.git"
refreshing repository
looking up first commit
looking up second commit
checking that commits are by bors and thus have ci artifacts...
finding bors merge commits
Expected author Brian Anderson to be bors for beb9a0dfc52ebda4f8db4e5d439e08e4f3a43a39

nagisa avatar Jan 03 '19 17:01 nagisa

a01b0bf0fbd870bec1747318bc081ac4a0606fb8 appears to be on the beta branch. I don't think this tool works with betas. Can you pick a revision from master?

ehuss avatar Jan 03 '19 17:01 ehuss

I can. I was just surprised at a very unintuitive message. FWIW I took a revision from master that did not happen to be a merge by bors and it failed the same way.

nagisa avatar Jan 03 '19 17:01 nagisa

Ah, yea, the error could definitely be better. I use git log --first-parent to make sure I'm looking at bors-only commits.

ehuss avatar Jan 03 '19 17:01 ehuss

This still appears to be an issue, even if the target commits are on master:

$ RUST_LOG=trace cargo-bisect-rustc -vv --script=./test.sh --test-dir=. --start=879e8aa7be06a53cd6cd9cc714e85a13c909c0ea
[2022-11-07T18:24:52Z TRACE reqwest::blocking::wait] (ThreadId(1)) park without timeout
[2022-11-07T18:24:52Z TRACE reqwest::blocking::client] (ThreadId(2)) start runtime::block_on
bisecting ci builds
starting at 879e8aa7be06a53cd6cd9cc714e85a13c909c0ea, ending at origin/master
opening existing repository at "rust.git"
Found origin remote under name `origin`
refreshing repository at "rust.git"
fetching (via local git) commits from 879e8aa7be06a53cd6cd9cc714e85a13c909c0ea to 68f77297c0f199e00ff98f4b6bd71a74e75ec09c
opening existing repository at "rust.git"
Found origin remote under name `origin`
refreshing repository at "rust.git"
looking up first commit
looking up second commit
checking that commits are by bors and thus have ci artifacts...
finding bors merge commits
[2022-11-07T18:24:57Z DEBUG cargo_bisect_rustc::git] 249b444efa356c252b264c56ba5041d70d0b9734 has non-bors author: Some("Steve Klabnik"), skipping
[2022-11-07T18:24:57Z DEBUG cargo_bisect_rustc::git] 9dedc815d97752f24a1073258d005d64c643ad80 has non-bors author: Some("Steve Klabnik"), skipping
[2022-11-07T18:24:57Z DEBUG cargo_bisect_rustc::git] ba872f270781ada15426cfac7db20b30b81777dc has non-bors author: Some("Brian Anderson"), skipping
[2022-11-07T18:24:57Z TRACE reqwest::blocking::client] closing runtime thread (ThreadId(2))
[2022-11-07T18:24:57Z TRACE reqwest::blocking::client] signaled close for runtime thread (ThreadId(2))
[2022-11-07T18:24:57Z TRACE reqwest::blocking::client] (ThreadId(2)) Receiver is shutdown
[2022-11-07T18:24:57Z TRACE reqwest::blocking::client] (ThreadId(2)) end runtime::block_on
[2022-11-07T18:24:57Z TRACE reqwest::blocking::client] (ThreadId(2)) finished
[2022-11-07T18:24:57Z TRACE reqwest::blocking::client] closed runtime thread (ThreadId(2))
ERROR: failed during attempt to create/access local git repository

Caused by:
    Expected author Brian Anderson to be bors for beb9a0dfc52ebda4f8db4e5d439e08e4f3a43a39.
     Make sure specified commits are on the master branch!

ngc0202 avatar Nov 07 '22 18:11 ngc0202

@ngc0202 cargo-bisect-rustc doesn't work with old commits like 879e8aa7be06a53cd6cd9cc714e85a13c909c0ea. IIRC, the max commit age is 167 days. The error could be better, but what you're trying won't work. Nightlies are available all the way back, although 2014 might be too old, too.

ehuss avatar Nov 08 '22 16:11 ehuss