cargo-bisect-rustc icon indicating copy to clipboard operation
cargo-bisect-rustc copied to clipboard

Add options to skip verifying bisection ranges

Open clubby789 opened this issue 1 year ago • 4 comments

Closes #258

Adds two options for bypassing verifying the start and end of nightly and CI ranges. If no start nightly has been provided, the start date will be detected as usual.

clubby789 avatar Feb 27 '23 17:02 clubby789

What's this feature doing? speeding up bisection by ignoring the start/end so you only run things in between the start/end?

oli-obk avatar Feb 28 '23 11:02 oli-obk

Yeah, if you know for sure that a regression happened between (for example) stable and beta, you can save some time by skipping checking those

clubby789 avatar Feb 28 '23 11:02 clubby789

Hmm... that needs a bit more documentation on the flags. To me it sounded like verifying that the commit/nightly exists or somehow is valid in itself. But this is solely about not running the bisection on the start/end and only running it between the given values

Also: why do we have different flags for CI artifacts and nightly?

oli-obk avatar Feb 28 '23 11:02 oli-obk

I'll update the help to document this better. I made two flags so that we don't skip verifying the CI range if the user has only provided nightly dates. It would probably make more sense to have it be a single flag that skips verifying whichever of the two the user has provided.

clubby789 avatar Feb 28 '23 12:02 clubby789