bors icon indicating copy to clipboard operation
bors copied to clipboard

Switch to `sqlx`

Open Kobzol opened this issue 9 months ago • 2 comments

I don't think that SeaORM is pulling its weight at the moment. Bors requires only a relatively simple database, and full ORM seems like an overkill to me. SeaORM requires us to have additional two crates in the workspace, juggle three different types per DB table, and it's not obvious to me what commands it executes and how it manages migrations.

For sake of transparency and easier understanding of what exactly we run against the DB, I would suggest to switch to sqlx.

Kobzol avatar May 03 '24 21:05 Kobzol

Do we need to migrate gradually from SeaORM to sqlx, or can we can just drop SeaORM and build sqlx models from scratch?

vohoanglong0107 avatar May 04 '24 03:05 vohoanglong0107

We don't need to do any incremental migration, we can just nuke the current DB, it's mostly empty anyway.

Kobzol avatar May 04 '24 07:05 Kobzol

Fixed by https://github.com/rust-lang/bors/pull/87. Thanks!

Kobzol avatar May 21 '24 13:05 Kobzol