bors icon indicating copy to clipboard operation
bors copied to clipboard

Add a container health check

Open marcoieni opened this issue 1 year ago • 1 comments

From the AWS console, the Health status of the task is Unknown:

image image

I found the docs on how to add an health check here.

We could define an health check to tell AWS when the app is ready to accept requests. E.g. the health check can be an http endpoint, so that we start receiving requests after the http server started.

What do you think?

marcoieni avatar Aug 07 '24 12:08 marcoieni

Yeah, that makes sense, should be easy to implement.

Kobzol avatar Aug 07 '24 12:08 Kobzol

the aws dashboard still shows "unknown" so I need to investigate

marcoieni avatar Sep 03 '24 15:09 marcoieni

https://github.com/rust-lang/simpleinfra/pull/559 I'll merge this tomorrow and check if it works in staging 👍

marcoieni avatar Sep 03 '24 15:09 marcoieni

Thanks! Bors is an important service (well, this specific bors instance hopefully will be important one day :laughing:), so if we can get a health check that could perhaps even alert us in some way if it goes offline, that would be nice.

Kobzol avatar Sep 03 '24 15:09 Kobzol

this specific bors instance hopefully will be important one day 😆

It will 😁

This is now done. Closing this 🎉

marcoieni avatar Sep 04 '24 08:09 marcoieni