book
book copied to clipboard
rust-lang
Fixed ch03-05-control-flow.md, replaced `for` with `while`
Hi team,
The section heading was Looping Through a Collection with for
and instead the explanation under it is about while.
Updated a link in ch12 which caused one of the job to fail
Please read that section again. It starts by explaining looping over a collection with the previously introduced while loop. Then it tells you there is a much better way by using for. So this section heading is correct.
@RafaelKr But the section under it explains all about how to loop over a collection using while instead of for.
Yes, but it does it to explain why using a while in this case isn't as good as for.
To be fair I read this very section the first time 2 hours ago and also wondered why it is labelled for and starts with a code block about a while loop. But after reading the section, things cleared up for me.
My suggestion is to update the wording of the first sentence instead:
- You can choose to use the while construct to loop over the elements of a collection
+ You could choose to use the while construct to loop over the elements of a collection
So changing can to could. This makes it clearer that while is a way to do it, but for is much better as explained later starting at However, this approach [using a while loop] is error prone; we could cause the program to panic if the index value or test condition is incorrect...
Closing in favor of #3758. The heading order here is intentional, but that small wording tweak should help. Thanks!
