async-book icon indicating copy to clipboard operation
async-book copied to clipboard

Migrate GitHub Pages deployment away from the static-websites action

Open miikka opened this issue 1 year ago • 4 comments

Background: https://github.com/rust-lang/simpleinfra/issues/597

This PR migrates the deployment to GitHub pages away from the custom static-websites GHA action to the official actinos/upload-github-pages-artifact and actions/deploy-pages actions.

For this to work, this repo needs to be configured to use GitHub Actions as the source for Pages.

I tested this in my own fork and it seemed to work (with the if: conditions commented out as they would prevent the interesting parts from running).

miikka avatar Oct 10 '24 14:10 miikka

As suggested from Miikka we need to change the settings of the repo immediately before merge the PR image

marcoieni avatar Oct 10 '24 15:10 marcoieni

Looks good to me, thanks 🙌 Let's wait for the maintainers of the repo to approve it 👍 After that, I can change the settings of the repo and merge the PR 🚀

marcoieni avatar Oct 11 '24 06:10 marcoieni

Hey @nrc, can the infra team take care of this? You don't need to review the PR, we'll merge it and make sure that the async book website still works and follow the latest best practices 👍

marcoieni avatar Nov 27 '24 13:11 marcoieni

Hey @nrc, can the infra team take care of this? You don't need to review the PR, we'll merge it and make sure that the async book website still works and follow the latest best practices 👍

That would be great, thank you!

nrc avatar Dec 03 '24 02:12 nrc

looks good image

marcoieni avatar Jun 06 '25 14:06 marcoieni

Thanks both and sorry if it took so long 😅 image

marcoieni avatar Jun 06 '25 14:06 marcoieni