thanks
thanks copied to clipboard
rust-lang-nursery
Contributor missing from 1.17 list
I think the list of contributors to 1.17 is incomplete -- so there seems to be a bug somewhere in the machinery that collects these stats.
Specifically, I am the author of commit 044ed10fee3351da2315d5d8e26949929ad918ce, which is new in 1.17:
$ git tag --contains 044ed10fee3351da2315d5d8e26949929ad918ce
1.17.0
However, my name does not appear on https://thanks.rust-lang.org/rust/1.17.0.
Sorry about that!
This is interesting; git log 1.17.0..beta or git log stable..beta does not seem to contain this commit. Hmmmmmmmm
Well, 1.17 has been released, so I'd rather expect it in git log 1.16.0..1.17.0, right? 1.16 doesn't even seem to have a tag, though... and git log 1.15.0..1.17.0 | fgrep Ralf does show something.
/cc @brson wrt the missing 1.16.0 tag
git log 1.15.0..1.17.0 | fgrep Ralfdoes show something.
☹️
So, historically what we base this off of is stable vs beta, basically, because that's how our branching model works. And we actually produce the list originally before the tag is even made, so we have to do it that way. But stable and 1.17.0 here, should be the same, so that shouldn't exactly matter......................
But stable and 1.17.0 here, should be the same, so that shouldn't exactly matter......................
And it doesn't, right? git log 1.15.0..origin/stable | fgrep Ralf shows the same.
git log 1.17.0..beta is for commits since stable, mine isn't in there. It is between 1.16 and 1.17.
I need to re-read the code. It does what we always did by hand originally.
This may be related, my name is not on the list for 1.17.0 either, and my commits https://github.com/rust-lang/rust/pull/39470/commits/fe324cea6490fc6e7ce16fb5209fde57cfa1b94f and https://github.com/rust-lang/rust/pull/39712/commits/e626a6807c44d097996b0f32a4e03b105837f9da are in 1.17.0.
https://thanks.rust-lang.org/rust/1.17.0 now says
We had 0 individuals contribute to 1.17.0. Thank you so much!
CC https://github.com/rust-lang-nursery/thanks/issues/103
