rustup.sh icon indicating copy to clipboard operation
rustup.sh copied to clipboard

Replace #!/bin/sh with #!/bin/bash

Open vi opened this issue 9 years ago • 6 comments

Should resolve #47.

vi avatar Apr 03 '16 13:04 vi

I strongly prefer to rewrite in portable shell code instead, or to not use a shell script at all for this (given the relative complexity of the script). How is rustup going to work satisfactorily on various platforms otherwise?

sanmai-NL avatar Apr 15 '16 11:04 sanmai-NL

rustup.sh may be obsoleted in favour of rustup.rs, so serious rewrite may be in vain.

vi avatar Apr 15 '16 11:04 vi

The script is not that non-portable at present at all. See e.g. this comment

Revised: if rustup.rs is a suitable replacement (soon) anyway, briefly depending on /bin/bash is better than the current situation anyway.

sanmai-NL avatar Apr 15 '16 11:04 sanmai-NL

@vi: I must have missed the announcement of the alternative tool in this repo? I hope this can be clarified so that you get to see a warning immediately when browsing this repo.

sanmai-NL avatar Apr 15 '16 12:04 sanmai-NL

@sanmai-NL, Main rustup.rs discussion thread is here: https://internals.rust-lang.org/t/beta-testing-rustup-rs/3316/83

vi avatar Apr 15 '16 12:04 vi

Sorry I've been ignoring this repo. From the linked issue, none of the bashisms seem fundamental. I'd rather just fix them. This script is likely to stick around for at least a few more months.

brson avatar May 03 '16 18:05 brson