error-chain icon indicating copy to clipboard operation
error-chain copied to clipboard

Shrink the size of all `Error` types

Open alexcrichton opened this issue 8 years ago • 5 comments
trafficstars

This commit improves the in-memory size of Error from 7 pointers to 1 pointer. Errors are in general relatively rare in applications and having a huge error type ends up generating lots of instructions for moves and such, so this PR optimizes for size and passing around errors rather than creating errors.

alexcrichton avatar Sep 23 '17 18:09 alexcrichton

Nice! You just have to update the tests which use pattern matching on the kind. It's also a breaking change so could you update the CHANGELOG?

Yamakaky avatar Sep 24 '17 09:09 Yamakaky

Updated

alexcrichton avatar Sep 24 '17 15:09 alexcrichton

Could you rebase please?

Yamakaky avatar Oct 11 '17 21:10 Yamakaky

Sure thing, done now

alexcrichton avatar Oct 12 '17 00:10 alexcrichton

When might this pull request be land/be merged?

Lymia avatar Oct 28 '17 04:10 Lymia