itertools icon indicating copy to clipboard operation
itertools copied to clipboard

implement arrays and next_array

Open conradludgate opened this issue 4 years ago • 2 comments

On the back of #547, starts implementing some more array features.

This one includes the arrays adapter and next_array method. They work exactly like their tuple counter parts.

It defines a new safe wrapper around [T;N] which starts out uninitialised and can be filled up safely, also implementing drop.

conradludgate avatar May 25 '21 20:05 conradludgate

It defines a new safe wrapper around [T;N] which starts out uninitialised and can be filled up safely, also implementing drop.

This is one of those things that it might be better to just bug std about stabilizing. It's already ended up with at least 4 different PRs adding something like that, because it's just an important building block for these things.

(Said otherwise, it'd be a shame to essentially be duplicating arrayvec in here, but it's probably not a good idea to add a dep for it either.)

I'm not the maintainer here, though, so take this comment with appropriate uncertainty.

scottmcm avatar May 25 '21 20:05 scottmcm

Said otherwise, it'd be a shame to essentially be duplicating arrayvec in here, but it's probably not a good idea to add a dep for it either.

I had no idea about this particular crate. I'm not against adding dependencies, although that's up to the maintainers. I've submitted a PR against that crate adding just 2 features I want. If decided, it could then be used here

conradludgate avatar May 25 '21 21:05 conradludgate