itertools icon indicating copy to clipboard operation
itertools copied to clipboard

Consider applying rustfmt to the code?

Open upsuper opened this issue 6 years ago • 3 comments

It seems that the code here doesn't follow the Rust style guide. Maybe consider applying rustfmt and add CI step to enforce it?

I think that would make people more comfortable to contribute, as they wouldn't need to think about what code style should they use, and can just rely on the tool to figure out.

upsuper avatar Sep 08 '19 11:09 upsuper

I agree with the premise that unclear formatting rules may be an obstacle for new potential contributors. However, my primary concern right now are existing potential contributors. Itertools has a considerable backlog of pull requests, and I want to avoid creating additional work for these patient contributors!

I'll revisit this after cutting down the number of pending pull requests.

jswrenn avatar Sep 30 '19 20:09 jswrenn

@jswrenn How about adding a .rustfmt.toml with ignore = "*" until you're done dealing with the PR backlog? That would improve the workflow for people who have their editors set up to run rustfmt on save.

jplatte avatar Jan 08 '20 23:01 jplatte

Great idea. Can you send in a PR? I'll accept it immediately.

jswrenn avatar Jan 08 '20 23:01 jswrenn