code
code copied to clipboard
rust-in-action
fix TOML in Cargo.toml
per https://toml.io/en/v1.0.0#inline-table, No newlines are allowed between the curly braces unless they are valid within a value.
Fixes #77.
FTR, looks like this PR (#91) will fix issue #102 that I filed yesterday for the same issue (it's unfortunate the PR title / details don't mention what is fixed in which Cargo.toml; so adding cross links to make it easier to find).
Ewen
the question is what needs to happen to get this PR merged 😄
@timClicks - are you still looking at this repo?
Yes I am! Sorry that I'm not very active.
I don't accept any PRs for copyright reasons.
On Thu, 12 Jan 2023 at 09:53, Dmitry Savintsev @.***> wrote:
the question is what needs to happen to get this PR merged 😄
@timClicks https://github.com/timClicks - are you still looking at this repo?
— Reply to this email directly, view it on GitHub https://github.com/rust-in-action/code/pull/91#issuecomment-1379471544, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGZ4IWCJ3UDQ3WUJXZYXDWR4MVDANCNFSM6AAAAAAR5R2SSM . You are receiving this because you were mentioned.Message ID: @.***>
I don't accept any PRs for copyright reasons.
@timClicks Perhaps you could at least put a note (near the top) of the README file that says "sorry I don't accept PRs for copyright reasons". Because there are ~18 months of PRs (including several duplicates) that people have created, trying to help, because they didn't know you weren't going to accept them. (Inexplicably GitHub still doesn't allow disabling PRs in a repo while leaving issues enabled :-( )
Ewen
I understand the frustration. I'll look into adding a note on the README. Leaving the PRs open was intended to make it less likely that there will be duplicate effort.