clap3 & irx-config

Open burrbull opened this issue 3 years ago • 3 comments

Sep 06 '22 06:09 burrbull

r? @adamgreig

(rust-highfive has picked a reviewer for you, use r? to override)

Sep 06 '22 06:09 rust-highfive

Looks okay in principle although I'm not super-psyched to rely on a crate which had a total of 453 downloads until now, a good fraction of which caused by this CI...

Sep 06 '22 12:09 therealprof

cc @Emilgardis

Sep 16 '22 13:09 burrbull

cc @Emilgardis Updated to clap 4.0

Oct 08 '22 08:10 burrbull

@Emilgardis Whoops, sorry, didn't notice you left a comment a while ago. Yes, fine by me. @burrbull If you could resolve the conflict...

Oct 12 '22 22:10 therealprof

LGTM, maybe I should close my PR then...

Oct 13 '22 00:10 luojia65

rebased

Oct 13 '22 06:10 burrbull

Build succeeded:

CI
Rustfmt

Oct 13 '22 11:10 bors[bot]