riscv icon indicating copy to clipboard operation
riscv copied to clipboard
verified publisher icon rust-embedded

Update to Rust edition 2024

Open romancardenas opened this issue 6 months ago • 7 comments

romancardenas avatar Jun 13 '25 20:06 romancardenas

Looks like we need to update all the crates at once... I will keep doing this when I have time

romancardenas avatar Jun 13 '25 20:06 romancardenas

@rmsyn I think it is done. The only test failing is a nightly clippy lint that is still unstable.

romancardenas avatar Jun 16 '25 16:06 romancardenas

@romancardenas fixed the lints in #301

rmsyn avatar Jun 17 '25 17:06 rmsyn

Please, point to this branch in this PR and I will merge it. I think we should leave this PR updated and ready to merge as soon as we decide to go with edition 2024

romancardenas avatar Jun 17 '25 18:06 romancardenas

as soon as we decide to go with edition 2024

After the discussion in today's meeting about updating svd2rust to edition 2024, I think the same arguments apply to the riscv crates, right? Since if riscv crates go to edition 2024, that would force svd2rust to update as well.

Linking the svd2rust discussion for tracking purposes: https://github.com/rust-embedded/svd2rust/pull/933#issuecomment-2954106460

rmsyn avatar Jun 17 '25 19:06 rmsyn

Yep, we can leave this PR open and updated to upgrade to edition 2024 whenever the WG decides it is worth it.

romancardenas avatar Jun 17 '25 19:06 romancardenas

This PR is being prevented from merging because it presents one of the blocking labels: work in progress, do not merge.

github-actions[bot] avatar Jun 18 '25 15:06 github-actions[bot]