embedded-alloc icon indicating copy to clipboard operation
embedded-alloc copied to clipboard

Add nrf softdevice feature

Open nospam2678 opened this issue 3 years ago • 1 comments

As has attempted to be described in the commit message, this is intended to address using this crate with Nordic Semiconductor's SoCs by adding a feature for acting slightly different with them. Since it adds a dependency on embassy, which is not yet distributed through crates.io, this is a draft pull request until the required crates have been stabilized.

There are likely improvements to be made to the details, but the main question should likely be; Could this addition stand a chance to get merged once the eco-system matures, or would doing this in some other way be considered a more appropriate solution?

nospam2678 avatar Jun 27 '22 15:06 nospam2678

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @adamgreig (or someone else) soon.

Please see the contribution instructions for more information.

rust-highfive avatar Jun 27 '22 15:06 rust-highfive

I think the right fix is to use critical-section. nrf-softdevice provides a critical section implementation suitable for the weird softdevice interrupt handling (currently for CS 0.2, this PR updates it to 1.0).

This way this crate works with all kinds of CS implementations without having to add them here.

See #56

Dirbaio avatar Aug 12 '22 13:08 Dirbaio

#56 sure looks like the better solution. I'm closing this attempt.

nospam2678 avatar Aug 24 '22 16:08 nospam2678