cargo-binutils icon indicating copy to clipboard operation
cargo-binutils copied to clipboard

Consider moving away from rustc-cfg?

Open brightly-salty opened this issue 4 years ago • 2 comments

It looks like rustc-cfg is unmaintained or at least dormant. There are no commits since October 2018, and it's dependence on failure (despite a PR to fix it) makes cargo-audit fail for cargo-binutils and anything that depends on it.

It might be better to move this functionality into cargo-binutils itself. rustc-cfg/src/lib.rs contains less than 200 lines of code, many of which are comments. If the licenses are compatible, I think it would be beneficial to move this file/code into cargo-binutils so it can continue to receive maintenance and updates.

brightly-salty avatar Jan 17 '21 22:01 brightly-salty

Fair enough. @japaric who's both the original author of the dependency in question and cargo-binutils might have an opinion on how we could proceed here.

therealprof avatar Jan 17 '21 23:01 therealprof

Importing rustc-cfg code into this repo seems fine to me. I think there's another crate that does about the same as rustc-cfg but I can't remember the name right now.

japaric avatar Feb 15 '21 12:02 japaric

rustc-cfg was updated in https://github.com/rust-embedded/cargo-binutils/pull/128

Emilgardis avatar Feb 03 '23 18:02 Emilgardis