book icon indicating copy to clipboard operation
book copied to clipboard

Published 20 hours ago • verified publisher icon rust-embedded

Use Rust 2018 syntax?

Open thejpster opened this issue 5 years ago • 4 comments

Should we be using Rust 2018 syntax in the book? The main change would be removing extern crate statements.

thejpster avatar Oct 10 '18 14:10 thejpster

agree but the suggested change has to be synchronized with the appropriate change in source code of the examples at github.com/rust-embedded/cortex-m-quickstart . I will help & fix both if someone explains me how to synchronize these Repos

hyperslv avatar Jun 12 '20 16:06 hyperslv

What do you mean by synchronize? Open PRs on both and then we'll merge them, couldn't be easier. 😅

therealprof avatar Jun 12 '20 18:06 therealprof

Created a PR on this issue

hyperslv avatar Jun 13 '20 16:06 hyperslv

This issue might be closed since the appropriate PR was merged.

hyperslv avatar Jun 15 '20 13:06 hyperslv

There are still some extern crate statements in the book. For example:

https://github.com/rust-embedded/book/blob/19f798d448835a4888e3b3eae7fe69f1d61d8681/src/peripherals/singletons.md?plain=1#L65

https://github.com/rust-embedded/book/blob/09986cd352404eb4659db44613b27cac9aa652fc/src/collections/index.md?plain=1#L33

Shall we fix them all?

Narukara avatar Jan 17 '23 01:01 Narukara

@Narukara I would welcome a PR fixing them all. We could then close this issue.

eldruin avatar Jan 17 '23 07:01 eldruin