refinery icon indicating copy to clipboard operation
refinery copied to clipboard

Give a name to the migrations example (#382)

Open kriswuollett opened this issue 10 months ago • 4 comments

kriswuollett avatar Apr 29 '25 07:04 kriswuollett

pull request is stale, going to close

jxs avatar Jul 25 '25 23:07 jxs

Why is the pull request stale? There is a linked issue for it that could be evaluated: closes #382.

kriswuollett avatar Jul 26 '25 00:07 kriswuollett

cause it introduces no changes, sorry. Do you want to update it? ah I see now that it's just renaming the main.rs, but you also need add it in the Cargo.toml as a binary

jxs avatar Jul 26 '25 12:07 jxs

cause it introduces no changes, sorry. Do you want to update it? ah I see now that it's just renaming the main.rs, but you also need add it in the Cargo.toml as a binary

You wish it to be added for documentation reasons? The package.autobins should be defaulting to true, so listing a named binary file in the manifest should be unnecessary unless customization is needed:

% cargo run --bin refinery-examples-migrate

...

warning: `refinery-core` (lib) generated 5 warnings (run `cargo fix --lib -p refinery-core` to apply 4 suggestions)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.10s
     Running `target/debug/refinery-examples-migrate`

kriswuollett avatar Jul 27 '25 01:07 kriswuollett