barrel icon indicating copy to clipboard operation
barrel copied to clipboard

Do not quote default values

Open cschmatzler opened this issue 4 years ago • 2 comments

Single-quoting the value makes it impossible to use functions.

Instead, the quoting should happen in the parameter to default().

This should also close #99.

cschmatzler avatar Jan 05 '21 22:01 cschmatzler

Updated the PR to do the same for SQLite and MySQL, should now also close #90.

cschmatzler avatar Jan 05 '21 22:01 cschmatzler

Hey, thanks for this PR.

Could you try rebasing your branch? I merged a bunch of PRs that have been open for way too long :see_no_evil:

Once that's taken care of I'll merge this without there being any tests for this because I'm planning on rebuilding the entire way that barrel is tested anyway

spacekookie avatar Jan 28 '21 17:01 spacekookie