team icon indicating copy to clipboard operation
team copied to clipboard

CLI Book – Rolling Review – DO NOT MERGE

Open killercup opened this issue 7 years ago • 2 comments

This pull request is not meant to ever be merged.

The book is written like this: New chapters will be added in PRs, where they get a bit of review, and finally get merged into master. Once they land in master, it's hard to leave review comments, though!

This PR is meant to give you a way to review the book and leave comments in an easy way. It shows the diff between master before I added the book and master right now, so it'll always show the full book, and also automatically mark comments as resolved once new content lands in master.

killercup avatar Aug 01 '18 09:08 killercup

Thanks so much for the thorough review, @stjepang! This is amazing!

By the way, the book was easy to follow and I learned something new while reading it. I like how unintimidating it is and assumes little prior knowledge. Great job!

Thank you!

Also thank you, @Dylan-DPC, for making a PR that includes a huge bunch of the suggestions applied! <3

killercup avatar Dec 08 '18 10:12 killercup

Pushed what I think is the rest of @stjepang's suggestions to master so it shows up here directly.

killercup avatar Dec 08 '18 12:12 killercup

@epage Shall we close this?

pksunkara avatar Aug 23 '22 14:08 pksunkara