human-panic
human-panic copied to clipboard
rust-cli
Determine rustc version and add it to the report
This is a 🙋 feature.
Checklist
- [x] tests pass
- [ ] tests and/or benchmarks are included - is this necessary/possible for this?
- [x] documentation is changed or added
Context
Fixes #31
Semver Changes
Major release - it changes the Report struct. I don't think 2.0 is released yet, so that would fit perfectly!
I have very little experience contributing to Rust crates, so if I made any mistakes, let me know!
Cargo also sets the RUSTC env var to the path to rustc. cargo -vV may not match rustc -vV. Especially when using a locally built toolchain using rustup toolchain link as in that case the default cargo (which is probably an official version) will be combined with the local rustc which in most cases has a huge version skew.
Cargo also sets the RUSTC env var to the path to rustc.
Did not know that! I'll update that right now.
@bjorn3 - getting this issue:
Compiling human-panic v1.0.4-alpha.0 (/home/thetechrobo/human-panic)
error: environment variable `RUSTC` not defined
--> /home/thetechrobo/human-panic/build.rs:6:22
|
6 | let cargo_path = env!("RUSTC");
| ^^^^^^^^^^^^^
|
= note: this error originates in the macro `env` (in Nightly builds, run with -Z macro-backtrace for more info)
error: could not compile `human-panic` due to previous error
I'm on nightly.
You should use std::env::var("RUSTC").unwrap() instead. RUSTC is passed at runtime of the build script, but not at compile time.
Should I rebase this PR, or are the maintainers fine with 7 (maybe more later if there's more review) commits?
It probably won't hurt to squash. No idea what the maintainers prefer though.