env_logger icon indicating copy to clipboard operation
env_logger copied to clipboard

Handle hyphens internally

Open Vagelis-Prokopiou opened this issue 3 years ago • 1 comments

With PR #77 a note about dashes in the crate name was added in the docs. The note was of course an essential addition.

I propose going a step further and handling the dashes internally, during the parsing (parse_spec() function). I believe this addition will save people time trying to debug the reason that the logging does not work as expected. I myself lost some time on this, even though I had read the docs, and I had read about the need to replace the dashes.

I would also have provided a PR too, but currently I am failing to build the library (see https://github.com/env-logger-rs/env_logger/issues/190#issuecomment-812988592).

Is there a valid reason for not handling the dashes internally?

Vagelis-Prokopiou avatar Apr 04 '21 07:04 Vagelis-Prokopiou

There is already a PR open for this: #177.

mainrs avatar Oct 09 '21 09:10 mainrs