bitcoind icon indicating copy to clipboard operation
bitcoind copied to clipboard

The fate of this repo

Open tcharding opened this issue 1 year ago • 6 comments
trafficstars

Recently I imported (stole) all the code from this crate and put it in the new bitcoind-json-rpc repository.

There is a PR in flight at the moment to replace usage of this crate in rust-miniscript.

We also have an open issue to move the new repo into the rust-bitcoin org.

We should have a discussion about the fate of this crate. Note that in the new repo this crate is renamed so there is no reason the crate/repo cannot go on living. It seems like a waste of resources however to maintain two copies of basically the same code in the rust-bitcoin org.

FTR I already got an explicit ACK by email from RCasatta to do the import.

tcharding avatar Jul 16 '24 23:07 tcharding

cc @RCasatta

tcharding avatar Jul 16 '24 23:07 tcharding

The fate of elementsd is similarly relevant.

FWIW I agree it's wasteful to duplicate effort. I think it'd be better if we PR'd to this repo to use the new json crate rather than bitcoin-core-rpc, since that dependency is the real reason for the fork.

apoelstra avatar Jul 17 '24 12:07 apoelstra

I think its better not PRing to this repo because:

  • this crate and bitcoin-json-rpc-client is so tightly coupled (eg the odd use of features for Core versions)
  • the changes to use it break totally rug bitcoincore-json-rpc

Those two things are what made me import it into the other repo and rename it.

tcharding avatar Jul 17 '24 19:07 tcharding

Ok, yeah, that makes sense.

apoelstra avatar Jul 17 '24 19:07 apoelstra

I think we should archive this repo and point users to rust-bitcoind-json-rpc/regtest once rust-bitcoind-json-rpc has been migrated to rust-bitcoin org

RCasatta avatar Aug 05 '24 13:08 RCasatta

What's the idea around electrsd after this crate now has been moved to rust-bitcoin and, IIUC, will be deprecated in favor of rust-bitcoind-json-rpc/regtest?

Will there be further work on electrsd, i.e., it will eventually update to use rust-bitcoind-json-rpc/regtest, or will it also get deprecated?

tnull avatar Aug 30 '24 08:08 tnull