nom icon indicating copy to clipboard operation
nom copied to clipboard

Fix Parsing Special Numbers

Open Alexhuszagh opened this issue 4 years ago • 3 comments

Closes #1384, by adding logic to specially handle special floating-point numbers. This should correctly handle both streaming and complete parsers, and the unittests seem to confirm this, but a double-check of my logic would be appreciated.

Alexhuszagh avatar Sep 10 '21 19:09 Alexhuszagh

@Stargateur Speaking of which, I'm guessing it's a good idea to not mark any internal functions public? I did this somewhat because nom does it a lot internally, but it's probably not a good idea...

Alexhuszagh avatar Sep 10 '21 23:09 Alexhuszagh

@Stargateur Speaking of which, I'm guessing it's a good idea to not mark any internal functions public? I did this somewhat because nom does it a lot internally, but it's probably not a good idea...

Oh, well, I think unless someone have a good reason yeah we should not introduce too many pub item.

Stargateur avatar Sep 10 '21 23:09 Stargateur

Ok I believe every requested change has been made.

Alexhuszagh avatar Sep 11 '21 00:09 Alexhuszagh