blackfriday
blackfriday copied to clipboard
russross
Request to tag the next v1.x version of Blackfriday so that Hugo can use it
Ref: https://github.com/gohugoio/hugo/issues/6040
Hello,
I discovered this issue recently from this comment in the Hugo Discourse forum.
The issue is that for a Markdown snippet:
- list item 1
```md
*hello*
```
- list item 2
list item 2 now gets nested under list item 1.
This issue wasn't there until Hugo v0.55.5. The last good Hugo version without this regression is v0.55.4.
Recreating this issue is very easy; just clone the below repo and run it with Hugo v0.55.4 vs Hugo v0.55.5, and see the difference:
- https://gitlab.com/hugo-mwe/hugo-v0.55.5-blackfriday-regression
My best bet is that this commit in Blackfriday caused this regression.
The regression was seen in Hugo in v0.55.5, because it's in that version that Blackfriday version was bumped to version v1.5.2 in this commit.
Example snippet
- List item 1
```md
*abc*
/def/
=def=
```
- List item 2
Rendering of above in Hugo v0.55.4
<ul>
<li><p>List item 1</p>
<pre><code class="language-md">*abc*
/def/
=def=
</code></pre></li>
<li><p>List item 2</p></li>
</ul>
List item 1
*abc* /def/ =def=List item 2
Rendering of above in Hugo v0.55.5 (regression)
<ul>
<li><p>List item 1</p>
<pre><code class="language-md">*abc*
/def/
=def=
</code></pre>
<ul>
<li>List item 2</li>
</ul></li>
</ul>
List item 1
*abc* /def/ =def=- List item 2
/cc @aignas Can you review if your Blackfriday commit referenced above caused this regression and can you please fix it?
