blackfriday icon indicating copy to clipboard operation
blackfriday copied to clipboard

Allow EXTENSION_HEADER_IDS {#id} also in alternative headers syntax.

Open bibainet opened this issue 6 years ago • 3 comments

Header text   {#id}
-------------------

bibainet avatar Oct 06 '17 21:10 bibainet

Hi @bibainet,

Sorry for the delay to take a look... There are some problems with this PR, some easy to address, some tougher.

Two easy ones (they're somewhat related): there are no tests, and that makes it difficult to understand what some of the commits are meant to accomplish. For example the first commit, Allow EXTENSION_HEADER_IDS {#id} also in alternative headers syntax. -- I can't decipher what it does. The tests would at least make it obvious what's the use case, and I could work from there.

A somewhat tougher problem is the fact that this PR is against master, which is v1 of Blackfriday, which is essentially in maintenance mode and should not get new features. Please take a look at the v2 branch, this is where active development is meant to happen.

And finally, the toughest problem is that some of the commits introduce changes to the way the source document text is interpreted. This proliferates extension zoo, and we run a serious risk of those extensions acting against one another and (even worse) base functionality. I'm trying to keep a complete halt on such extensions until we adopt CommonMark, which at least has a very extensive set of tests with good coverage of corner cases.

Having said that, I will close this PR, it shouldn't land. But I will be happy to help you move some of these commits to v2, and for those that wouldn't go to v2, let's try to find a solution that could live as an external extension to Blackfriday, in your own repo. Does that work for you?

If you'd wish to continue with the above, please file a separate issue for each extension that you propose, complete with sample markdown inputs and HTML outputs, and let's discuss each separately.

rtfb avatar Oct 13 '17 17:10 rtfb

Hi @rtfb ,

I will return to this later. Now I do not have time to do it.

bibainet avatar Oct 21 '17 09:10 bibainet

Yup, no problem! :-)

rtfb avatar Oct 21 '17 09:10 rtfb