multiplatform-settings icon indicating copy to clipboard operation
multiplatform-settings copied to clipboard

Stabilize `KeychainSettings`

Open russhwolf opened this issue 2 years ago • 10 comments

Currently, KeychainSettings is considered experimental because I want to be cautious about security-related APIs and I've had very little feedback. Please report this ticket if it is or isn't working for you so I can get a sense of when it's ready to be marked stable.

russhwolf avatar Jul 17 '22 21:07 russhwolf

This is NOT blocked by #71. There are currently no known issues, just a lack of testing and feedback.

russhwolf avatar Jul 17 '22 22:07 russhwolf

Switched out NSUserDefaultSettings with KeychainSettings. I've tried using it once, got the feedback that it wasn't working. Like the values weren't persisted. Didn't look into it again though. Could be something on my side as well. Lazy: Is there anything that needs to be enabled on iOS side in order to use the Keychain?

vanniktech avatar Jul 17 '22 22:07 vanniktech

There shouldn't be any extra config necessary. The sample app has an option to use it so maybe compare against that.

russhwolf avatar Jul 18 '22 03:07 russhwolf

Just wondering if KeychainSetting would also implement ObservableSettings in the future as well?

archiegq21 avatar Oct 13 '22 01:10 archiegq21

See #71. Unfortunately, I'm not aware of a way to observe keychain updates that works outside of macOS.

russhwolf avatar Oct 14 '22 01:10 russhwolf

Just to let you know we use KeychainSettings in one of our projects and it works nicely!

lukepistrol avatar Jan 16 '23 12:01 lukepistrol

Can't this be closed since 1.0.0 is released?

vanniktech avatar Jan 16 '23 18:01 vanniktech

It's still marked experimental in 1.0.0

russhwolf avatar Jan 19 '23 04:01 russhwolf

Using KeychainSettings in a project at the moment, providing a couple extra default properties (kSecAttrAccessible & kSecAttrAccessGroup) – seems to be working well, haven't found any issues (will update if there are any)

Edit: opened #144

sebj avatar Feb 10 '23 14:02 sebj