modernizr-rails icon indicating copy to clipboard operation
modernizr-rails copied to clipboard

Allow configuration on the fly

Open ream88 opened this issue 11 years ago • 1 comments

The latest few issues (#19, #20, #21) showed up a big problem of this gem: Not everybody needs the same setup, and some features of Modernizr even break some setups.

A few solutions I thought of:

  • I'm only bundling the dev built anymore: If somebody needs a special version of Modernizr, they have to bring their own. We should not accept such pull requests anymore. This is the quickest solution for now, and I will update the README about this change.
  • Some kind of building system: A Modernizr build is assembled by Grunt from lots of separate files. Maybe we can translate this functionality into the Rails Asset Pipeline somehow. Usage would be following:
#= require modernizr # for the whole Modernizr build
#= require modernizr-css # only for the CSS tests
#= require modernizr-touch-events # only for one particular test, in this case touch events

Any ideas and suggestions? @russfrisch @mltsy

ream88 avatar Jun 07 '13 08:06 ream88

I agree with your first point and I love the idea of your second point. With the power of Asset Pipeline to combine and minify the various modernizr pieces into a single file I can't think of a reason not to go this route.

Russ Frisch http://about.me/russfrisch

On Fri, Jun 7, 2013 at 4:04 AM, Mario Uher [email protected] wrote:

The latest few issues (#19https://github.com/russfrisch/modernizr-rails/issues/19, #20 https://github.com/russfrisch/modernizr-rails/issues/20, #21https://github.com/russfrisch/modernizr-rails/issues/21) showed up a big problem of this gem: Not everybody needs the same setup, and some features of Modernizr even break some setups.

A few solutions I thought of:

  • I'm only bundling the dev built anymore: If somebody needs a special version of Modernizr, they have to bring their own. We should not accept such pull requests anymore. This is the quickest solution for now, and I will update the README about this change.
  • Some kind of building system: A Modernizr build is assembled by Grunt http://gruntjs.com from lots of separate files. Maybe we can translate this functionality into the Rails Asset Pipeline somehow. Usage would be following:

#= require modernizr # for the whole Modernizr build#= require modernizr-css # only for the CSS tests#= require modernizr-touch-events # only for one particular test, in this case touch events

Any ideas and suggestions? @russfrisch https://github.com/russfrisch @mltsy https://github.com/mltsy

— Reply to this email directly or view it on GitHubhttps://github.com/russfrisch/modernizr-rails/issues/23 .

russfrisch avatar Jun 07 '13 15:06 russfrisch