srt-rs icon indicating copy to clipboard operation
srt-rs copied to clipboard

Published 20 hours ago • verified publisher icon russelltg

Please do not use custom Debug

Open lu-zero opened this issue 4 years ago • 2 comments

The current custom implementations make much harder to debug since useful information stays omitted.

If you are fine with it, I can send a PR that either removes or changes the current impls to Display.

lu-zero avatar Jan 22 '21 15:01 lu-zero

I'm happy to change my custom debugs to include the info you want, but the default debug for packets are huge and noisy, so I made it a bit easier to read.

russelltg avatar Jan 23 '21 14:01 russelltg

The peer_addr would had been nice to have, but in general it was not really nice when I had to dump the packet for writing the test.

lu-zero avatar Jan 23 '21 15:01 lu-zero