go-pingdom icon indicating copy to clipboard operation
go-pingdom copied to clipboard

Published 20 hours ago • verified publisher icon russellcardullo

Modify check without removing values

Open RafPe opened this issue 6 years ago • 2 comments

This PR ensures that we have method which allows update without removing of current values within HTTP checks.

RafPe avatar May 14 '18 14:05 RafPe

This is okay for now, but I think longer term would be better to have a single method that accepts optional values. So if we merged this it would really be short term until we get a chance to rework everything to be optional.

I'll have some time to look into that next week.

russellcardullo avatar May 24 '18 22:05 russellcardullo

@russellcardullo I completely agree with you that this is temporary. I believe we could help out in work towards making certain things optional.

If you could merge it this week that would really help us out :)

RafPe avatar May 29 '18 10:05 RafPe