dupree icon indicating copy to clipboard operation
dupree copied to clipboard

Replace pr-commands.yaml with pre-commit rules

Open russHyde opened this issue 2 years ago • 1 comments

Aim, to ensure that styler::style_pkg() and devtools::document() are ran on every commit. This should keep the code clean, and is more hands off than having PR discussion commands for styling and documenting the code.

russHyde avatar Jan 30 '23 10:01 russHyde

Note there have been some issues doing this.

  • The pre-commit lint rule needs to be turned off (because it flags lots of needless object-usage errors)
  • Dependencies in ./presentations/ should be ignored, they do not need to be in DESCRIPTION (? how to ignore this folder in "deps-in-desc" rule)
  • ./docs, ./presentations and ./tests/testthat/testdata should not be modified (by styler etc)

russHyde avatar Jan 30 '23 11:01 russHyde