Roman Useinov
Roman Useinov
Would appreciate input in terms of logic soundness for `can_reserve`. The important differences between the current code and the last review: 1. `keep_alive` for `can_hold` has been reverted as we...
A bit stuck on this one while fixing other pallets, duplicating my post in FRAME Element room for posterity: Basically, after introducing the change to can_reserve and reserve we have...
This breaks the current implementation of `contracts` pallet, currently blocked until @athei figures out how we want to go about those changes.
Additional notes: Modify pallet-balances to take care of the below: ``` having a non-zero reserved balance should imply a consumer ref. anything which alters the reserved balance should inc consumer...
> > But I'm not sure how this can solve the contracts issue. Because if we only transfer the ED - it will be unreserved and therefore there won't be...
This has been stale for a while as we did not reach consensus on how to proceed with this as far as I understand. This should fix it: https://github.com/paritytech/substrate/pull/12951
> Sorry for silly question but in frame_system pallet > > ```rust > 2 /// The aggregated event type of the runtime. > 1 type RuntimeEvent: Parameter > 299 +...
As far as I'm concerned this is already done as the `Cursor` has `Read` implementation that does all that.
> Hm it's been 3 years since I submitted that issue, so I don't remember details, but I believe it was about zero-copied slices of the original file whereas standard...